fix(styles): treat newlines/tabs as CSS descendant combinators in encapsulation#175
Merged
Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom Mar 27, 2026
Conversation
…apsulation split_by_combinators() only recognized ' ' (space) as a whitespace descendant combinator, missing '\n', '\t', and '\r'. When a comment placeholder (%COMMENT%) was followed by a newline, the placeholder and selector merged into one part, causing scope_simple_selector to bail out and skip scoping the first rule entirely. This surfaced when SCSS @import pulled in files with block comments — Sass hoists the comment before the first rule, and the newline after it triggered the bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue where if a style had a comment before it, the style was not encapsulated.
split_by_combinators()only recognized' '(space) as a whitespace descendant combinator, missing\n,\t, and\r%COMMENT%) was followed by a newline, the placeholder and selector merged into one part, causingscope_simple_selectorto bail out and skip scoping the first rule@importpulled in files with block comments — Sass hoists the comment before the first rule, and the newline after it triggered the bugTest plan
:hostwith newline combinator