Repository navigation
Align the custom CSS property handler with the 2026-09 CSS engine - #66
Merged
Merged
Conversation
The bundle now requires the css.core, css.swt and css.swt.theme versions shipped with Eclipse 4.41, whose rewritten CSS engine keeps the property handler API unchanged. The checkbox handler drops the redundant ICSSPropertyHandler implements clause, since AbstractCSSPropertySWTHandler already implements it. Assisted-by: multiple AI agents and layers of automated tooling 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eclipse 4.41 replaced the Batik based CSS parser and the SAC value model with an internal implementation and folded ICSSPropertyHandler2 into ICSSPropertyHandler.
The property handler API stayed source compatible, so CheckboxPropertyHandler only drops its redundant interface clause and keeps converting values through the CSS engine, which is the supported way to read the new value records.
The required CSS bundle versions now point to the 4.41 releases.