fix(xml): verify nested closing tag names in readContent#149
Merged
Conversation
Maintain a tag stack inside XmlParser.readContent so that every closing tag of a nested element is validated against the name of the element that opened it. Previously the name was read and silently discarded, accepting malformed XML like <col><a>text</b></col> without error. Closes #134
vmvarela
added
type:chore
github-actions
Bot
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayList([]const u8)tag stack insideXmlParser.readContentto track open nested element namesdepth > 0, verifies the name matches the top of the stack; callsfatalAton mismatchXmlParser.readContent: properly matched nested tags are accepted) verifying the stack mechanism handles deeply nested valid XML correctly<a>text</b>exits non-zeroChanges
src/xml.zig:readContent— replace discarded_ = self.readName()with stack push/pop + verification; add unit testbuild.zig: integration test 132 for mismatched nested closing tagCloses #134