Repository navigation
fix(ci): bundle the C++ runtime in the Linux wheels (auditwheel); version 0.9.7 - #12
Merged
Merged
Conversation
…r); version 0.9.7 The Linux wheels were hand-retagged manylinux_2_28 without auditwheel, so libIDAWin.so's libc++, libc++abi and libunwind were never bundled and pyvcell_odesolver fails to load on a stock Linux (libc++.so.1: cannot open shared object file). The new verify-wheels job installs each Linux wheel on clean runners and solves a reference input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
libc++ needs libatomic.so.1, which auditwheel leaves to the system, and a minimal Rocky 8 does not have it (verify-wheels on rockylinux:8: libatomic.so.1: cannot open shared object file). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ired wheel put it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. pyvcell-odesolver 0.9.6's Linux wheels don't load on a stock Linux:
libIDAWin.solinks clang'slibc++.so.1,libc++abi.so.1andlibunwind.so.1. The Linux job retagged the wheelmanylinux_2_28_*by hand (wheel tags --platform-tag) instead of runningauditwheel repair, so those libraries were never bundled. The release archives don't have this problem, becausepackage_linux.shbundles them. pyvcell'ssimulate_odetests fail on ubuntu runners for this reason (virtualcell/pyvcell#65).Changes
dist/, tags itlinux_<arch>, then runsauditwheel repair --plat manylinux_2_28_<arch>. It finds the three libraries in clang's resource tree, the same lookup aspackage_linux.sh, andauditwheel showprints the result.verify-wheelsjob: installs each Linux wheel into a fresh venv on clean runners (ubuntu-24.04, ubuntu-24.04-arm, rockylinux:8 for glibc 2.28). It callsversion()and solvestests/reference/cvode_simple.cvodeInput, comparing against the reference output.publish-to-pypinow needs it.Not tested locally. Docker ran out of disk pulling the fvsolver build image, so this PR's CD run is the first test.
🤖 Generated with Claude Code