Skip to content

Fix bypass-cloud workflow after upstream auth helper relocation - #1

Merged
vhbui02 merged 2 commits into
masterfrom
copilot/fix-bypass-cloud-failure
Oct 14, 2026
Merged

vhbui02 merged 2 commits into
masterfrom
copilot/fix-bypass-cloud-failure

Conversation

Copilot AI commented Oct 14, 2026 •

Copy link
Copy Markdown

The scheduled Bypass Cloud workflow started failing because its auth patch guard targeted an outdated source file path. The job aborted before applying bypass changes when upstream moved the access helper implementation.

  • Root cause

    • .github/workflows/bypass-cloud.yml still checked and patched http_access_user_has_enough_access_level_for_endpoint in src/web/api/http_auth.h, but upstream now defines it in src/libnetdata/user-auth/http-access.h.
  • Workflow updates

    • Retargeted the auth guard check to src/libnetdata/user-auth/http-access.h.
    • Retargeted the sed patch operation to the same file.
    • Updated git add to stage src/libnetdata/user-auth/http-access.h instead of the old path.
  • Patch scope

    • No behavior change to bypass logic itself; only path alignment with current upstream layout.
# before
sed -n '/static inline bool http_access_user_has_enough_access_level_for_endpoint/,/}/p' "src/web/api/http_auth.h"
sed -i '/static inline bool http_access_user_has_enough_access_level_for_endpoint/,/}/ s/[ \t]*return ((user & endpoint) == endpoint);/    return true;/' "src/web/api/http_auth.h"
git add "src/web/api/http_auth.h" ".github/workflows/packaging.yml"

# after
sed -n '/static inline bool http_access_user_has_enough_access_level_for_endpoint/,/}/p' "src/libnetdata/user-auth/http-access.h"
sed -i '/static inline bool http_access_user_has_enough_access_level_for_endpoint/,/}/ s/[ \t]*return ((user & endpoint) == endpoint);/    return true;/' "src/libnetdata/user-auth/http-access.h"
git add "src/libnetdata/user-auth/http-access.h" ".github/workflows/packaging.yml"

Co-authored-by: vhbui02 <80348187+vhbui02@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job bypass-cloud Fix bypass-cloud workflow after upstream auth helper relocation Oct 14, 2026
Copilot AI requested a review from vhbui02 October 14, 2026 16:14

@vhbui02 vhbui02 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :")

@vhbui02
vhbui02 marked this pull request as ready for review October 14, 2026 16:16
Copilot AI balanced review requested due to automatic review settings October 14, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vhbui02
vhbui02 merged commit ee89872 into master Oct 14, 2026
105 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants