Skip to content

Support the rarer extension equality operators - #148

Draft
jaybosamiya wants to merge 1 commit into
mainfrom
jayb/fix-145
Draft

jaybosamiya wants to merge 1 commit into
mainfrom
jayb/fix-145

Conversation

@jaybosamiya

@jaybosamiya jaybosamiya commented Jun 22, 2025 •

Copy link
Copy Markdown
Collaborator

Warning

We are considering removing !~= and !~~= operators from Verus, thus we might not wish to merge this PR.

This PR adds support for the rarer extensional equality operators (!~= and !~~=, which are the evil negation twins of =~= and =~~= respectively; see verus#23ac0b0).

Closes #145.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@jaybosamiya
jaybosamiya requested a review from parno June 22, 2025 09:00
@jaybosamiya
jaybosamiya enabled auto-merge (squash) June 22, 2025 09:00

@parno parno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue, but are we sure Verus should be supporting such things? I didn't realize Verus included them, and they're pretty ugly.

@jaybosamiya-ms
jaybosamiya-ms disabled auto-merge June 25, 2025 01:55
@jaybosamiya-ms

Copy link
Copy Markdown
Collaborator

I don't particularly like these operators either, tbqh (you'll notice that I call them the "evil negation twins" for a reason 🙃). I too hadn't realized that Verus had included them until I went searching for them. They've existed for ~2 years, and the fact that no one has actually hit this issue until recently for verusfmt implies that no one is actively using them. If folks want to pull this out of Verus, and we thus don't merge this into verusfmt, that would be fine by me.

@parno

parno commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

There was some support at the Verus meeting today for removing those operators, so perhaps we should hold off merging this for now.

@jaybosamiya-ms
jaybosamiya-ms marked this pull request as draft October 24, 2025 23:49
@jaybosamiya-ms

Copy link
Copy Markdown
Collaborator

Marked as draft so it doesn't look like an approved PR that is just waiting to be merged. Once it these operators are ripped out of Verus, we should close this PR and close #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to parse !~=

3 participants