datatables 2.x version issues#694
Merged
Merged
Conversation
vedmack
approved these changes
May 3, 2026
vedmack
left a comment
vedmack
left a comment
Owner
There was a problem hiding this comment.
thanks for the contribution! gonna update the showcase page with this and prompte to yadcf 2.0.1.beta.10
|
Related: #681 |
Owner
|
@louking sorry, my bad, forgot to merge your PR, so I just did now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$.fn.yadcf(jQuery plugin), this (the jQuery object) is passed as oTable to initAndBindTable, so oTable is a jQuery object — not a DataTables API object. But the DataTables 2 path at line 3281 calls oTable.table() which only exists on a DataTables API instance. The fix is to wrap oTable withnew $.fn.dataTable.Api(oTable), which already handles jQuery objects (same pattern used in getSettingsObjFromTable).