Skip to content

add build in Docker - #332

Open
karu2003 wants to merge 7 commits into
vedderb:masterfrom
karu2003:docker
Open

add build in Docker#332
karu2003 wants to merge 7 commits into
vedderb:masterfrom
karu2003:docker

Conversation

@karu2003

Copy link
Copy Markdown

simple project build in Docker. no garbage in the system.

@github-actions

github-actions Bot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@karu2003

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Oct 30, 2023
@karu2003
karu2003 force-pushed the docker branch 3 times, most recently from 26f0ec5 to 7eb52ac Compare November 6, 2023 18:42
@karu2003
karu2003 force-pushed the docker branch 2 times, most recently from 533f43a to a39a198 Compare January 2, 2025 07:18
@albfan

albfan commented Feb 1, 2025

Copy link
Copy Markdown

Whatever the process to get into this changes you should rework into atomic meaningful changes.

Some of the probably might be cherry-picked (like config the jobs in make, but not really related with this PR

@albfan albfan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a general config for this.

If you want to do that as a build on docker, why someone will not want to build firmware?

force config on a docker build is wrong

@albfan albfan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash into atomic change

@albfan albfan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use meaningful commit messages.

If you want to use the cpus available say so on commit

@albfan albfan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash

@albfan albfan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash into an atomic change

@karu2003

Copy link
Copy Markdown
Author

Whatever the process to get into this changes you should rework into atomic meaningful changes.

Some of the probably might be cherry-picked (like config the jobs in make, but not really related with this PR

you can close PR. it's been a long time. i use docker for myself.

@karu2003

Copy link
Copy Markdown
Author

you can close PR. it's been a long time. i use docker for myself.

@albfan

albfan commented Apr 28, 2025

Copy link
Copy Markdown

You should close yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants