feat(xo-web/setting/remotes): ability to change the type of a remote#3207
Merged
feat(xo-web/setting/remotes): ability to change the type of a remote#3207
Conversation
badrAZ
changed the title
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
from
a590844 to
0324997
Compare
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
2 times, most recently
from
744832a to
0c51911
Compare
julien-f
reviewed
Jul 20, 2018
| export const toggleState = (_, { target: { name } }) => state => ({ | ||
| ...state, | ||
| [name]: !state[name], | ||
| }) |
Member
There was a problem hiding this comment.
Maybe create a dedicated freactal-utils module?
Also, add a link to the related Freactal issue and a todo to remove them once resolved.
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
from
0c51911 to
8b7fb0b
Compare
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
from
8b7fb0b to
7bbb2b8
Compare
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
from
7bbb2b8 to
06f0f20
Compare
4 tasks
badrAZ
force-pushed
the
settingsRemotes-childrenComponent
branch
from
18b5393 to
5619373
Compare
pdonias
requested changes
Jul 25, 2018
| export const linkState = (_, { target }) => state => ({ | ||
| ...state, | ||
| [target.name]: | ||
| target.nodeName.toLowerCase() === 'input' && |
Contributor
Author
There was a problem hiding this comment.
IMHO, to handle the case when it's used in a wrapped checkbox input. I just copy/past the @julien-f implementation.
pdonias
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2423
Screenshot
Check list
Fixes #007)${name} v${new version})Process
WiP:(Work in Progress) if not ready to be merged