Repository navigation
Dim the whole scene evenly instead of backing text - #22
Merged
Merged
Conversation
…instead of outlining text Tuned with the owner in a live preview. This supersedes the planned halo widening (reach 6.5/7/8): use reach 11/12/14.
# Conflicts: # src/engine.tsx
The owner preferred an even darkening to a backing around text: the scene now fades 60/65/70% of the way to the scrim color at subtle/normal/vivid. The distance field around text only decides where clicks land and the text map scenes get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scene now fades evenly 60/65/70% of the way to the scrim color (subtle/normal/vivid) instead of getting a dark backing around text, which read as an outline. Text has no backing of its own; the distance field around text now only decides where clicks land and the text map scenes get, so the per-cell rescrim bookkeeping is gone.
Before (main) | after, beach day and tundra night:
Verified: typecheck, build,
dev/check.tsin octant and quadrant modes and--verify-dirtyon all 90 combinations (0 failed), screenshots unchanged (they are raw scene renders).