Update entity property sorting to be based off of class inheritence#105
Merged
Conversation
HL-RamonZubiate
approved these changes
Mar 19, 2026
HL-RamonZubiate
left a comment
HL-RamonZubiate
left a comment
There was a problem hiding this comment.
LGTM - Will make a note in our next 1-1 since I kinda want to recognize patterns where using reflection makes sense in our codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates sorting of properties in the
Entity::buildSchema()to respect class inheritence.This helps keep consistent sorting for authenticator schemas (and their forms) and also helps with API output by putting common/baseclass fields before subtype specific fields.