Skip to content

Update Uganda holidays: add 2026 general elections public holidays - #3701

Open
uttam12331 wants to merge 3 commits into
vacanza:devfrom
uttam12331:uganda-2026-election-holidays
Open

Update Uganda holidays: add 2026 general elections public holidays#3701
uttam12331 wants to merge 3 commits into
vacanza:devfrom
uttam12331:uganda-2026-election-holidays

Conversation

@uttam12331

Copy link
Copy Markdown
Contributor

Proposed change

President Museveni declared 15 and 16 January 2026 public holidays to allow citizens to take part in Uganda's 2026 general (presidential and parliamentary) elections, by Legal Notice under the Public Holidays Act.

Adds them via a new UgandaStaticHolidays class (Uganda had no StaticHolidays group before).

Source

  • Daily Monitor — "Museveni declares two-day public holiday for elections"; New Times / ChimpReports (gazetted Legal Notice under the Public Holidays Act).

Checklist

  • 2026-01-15 and 2026-01-16 = "General elections"; absent all other years.
  • tests/countries/test_uganda.py passes (23 passed); ruff clean.
  • Commit signed off (DCO).

President Museveni declared 15 and 16 January 2026 public holidays for the
general (presidential and parliamentary) elections, by Legal Notice under the
Public Holidays Act. Add them via a new UgandaStaticHolidays class.

Signed-off-by: uttam12331 <uttam12331@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Summary by CodeRabbit

  • New Features

    • Added Uganda’s 2026 general election holidays on January 15 and 16.
    • These dates are now included in Uganda’s holiday calendar.
  • Tests

    • Added coverage to verify both election holiday dates.

Walkthrough

Uganda now supports static “General elections” holidays on January 15 and 16, 2026. The country calendar loads the Uganda-specific configuration, with corresponding test assertions and snapshot entries.

Changes

Uganda static holiday support

Layer / File(s) Summary
Static holiday configuration and validation
holidays/countries/uganda.py, tests/countries/test_uganda.py, snapshots/countries/UG_COMMON.json
Uganda initializes StaticHolidays with UgandaStaticHolidays, mapping “General elections” to January 15–16, 2026. Tests and snapshots record both dates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: arkid15r, ppsyrius

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the Uganda holiday update and the 2026 General elections entries.
Description check ✅ Passed The description matches the Uganda 2026 election holiday additions and test/snapshot updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c382fde) to head (112e840).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #3701   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          321       321           
  Lines        19320     19325    +5     
  Branches      2477      2477           
=========================================
+ Hits         19320     19325    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/countries/test_uganda.py Outdated
Comment thread holidays/countries/uganda.py Outdated
@KJhellico KJhellico changed the title Add Uganda 2026 general election public holidays Update Uganda holidays: add 2026 general elections public holidays Jul 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/countries/test_uganda.py`:
- Around line 26-31: Update test_special_holidays to retain assertions that
“General elections” is absent for 1963–2025 and 2027–2049, while preserving the
existing 2026-01-15 and 2026-01-16 assertions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b7d74dfd-09c3-4f4f-b129-df66dbfc3104

📥 Commits

Reviewing files that changed from the base of the PR and between 9bef12e and 112e840.

📒 Files selected for processing (3)
  • holidays/countries/uganda.py
  • snapshots/countries/UG_COMMON.json
  • tests/countries/test_uganda.py

Comment thread tests/countries/test_uganda.py

@KJhellico KJhellico left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PPsyrius PPsyrius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minute capitalization fixes

Comment on lines +120 to +121
# General elections.
general_elections = "General elections"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO Elections should've been capitalized

Suggested change
# General elections.
general_elections = "General elections"
# General Elections.
general_elections = "General Elections"

Comment on lines +773 to +774
"2026-01-15": "General elections",
"2026-01-16": "General elections",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"2026-01-15": "General elections",
"2026-01-16": "General elections",
"2026-01-15": "General Elections",
"2026-01-16": "General Elections",


def test_special_holidays(self):
self.assertHolidayName(
"General elections",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"General elections",
"General Elections",

"""Uganda special holidays.

References:
* [General elections 2026](https://web.archive.org/web/20260112000421/https://eagle.co.ug/2026/01/10/museveni-declares-jan-15-16-as-public-holidays-for-general-elections/)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [General elections 2026](https://web.archive.org/web/20260112000421/https://eagle.co.ug/2026/01/10/museveni-declares-jan-15-16-as-public-holidays-for-general-elections/)
* [General Elections 2026](https://web.archive.org/web/20260112000421/https://eagle.co.ug/2026/01/10/museveni-declares-jan-15-16-as-public-holidays-for-general-elections/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants