Skip to content

chore: warn about deprecated packages instead of failing the update#24619

Merged
caalador merged 1 commit into
mainfrom
deprecate-warning-only
Jun 15, 2026
Merged

chore: warn about deprecated packages instead of failing the update#24619
caalador merged 1 commit into
mainfrom
deprecate-warning-only

Conversation

@Artur-

@Artur- Artur- commented Jun 12, 2026

Copy link
Copy Markdown
Member

The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR.

The frontend dependency update script previously exited with an error
when deprecated packages were detected, preventing the update PR from
being created. Now the script always completes and exports the
deprecation details via GITHUB_ENV so the workflow appends them as a
warning to the commit message of the generated PR.
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

 1 447 files  ±0   1 447 suites  ±0   1h 25m 8s ⏱️ -46s
10 217 tests ±0  10 149 ✅ ±0  68 💤 ±0  0 ❌ ±0 
10 689 runs  ±0  10 620 ✅ ±0  69 💤 ±0  0 ❌ ±0 

Results for commit b3e6671. ± Comparison against base commit 840472c.

@caalador caalador added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit e671b53 Jun 15, 2026
34 checks passed
@caalador caalador deleted the deprecate-warning-only branch June 15, 2026 03:54
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 25.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e671b53
error: could not apply e671b53... chore: warn about deprecated packages instead of failing the update (#24619)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 25.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e671b53
error: could not apply e671b53... chore: warn about deprecated packages instead of failing the update (#24619)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e671b53
error: could not apply e671b53... chore: warn about deprecated packages instead of failing the update (#24619)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e671b53
error: could not apply e671b53... chore: warn about deprecated packages instead of failing the update (#24619)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Artur- added a commit that referenced this pull request Jun 16, 2026
…24619) (CP: 25.2) (#24632)

The frontend dependency update script previously exited with an error
when deprecated packages were detected, preventing the update PR from
being created. Now the script always completes and exports the
deprecation details via GITHUB_ENV so the workflow appends them as a
warning to the commit message of the generated PR.
vaadin-bot added a commit that referenced this pull request Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 24.10) (#24643)

This PR cherry-picks changes from the original PR #24632 to branch
24.10.
---
#### Original PR description
> The frontend dependency update script previously exited with an error
when deprecated packages were detected, preventing the update PR from
being created. Now the script always completes and exports the
deprecation details via GITHUB_ENV so the workflow appends them as a
warning to the commit message of the generated PR.
>

Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 24.9) (#24644)

This PR cherry-picks changes from the original PR #24632 to branch 24.9.
---
#### Original PR description
> The frontend dependency update script previously exited with an error
when deprecated packages were detected, preventing the update PR from
being created. Now the script always completes and exports the
deprecation details via GITHUB_ENV so the workflow appends them as a
warning to the commit message of the generated PR.
>

Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 25.1) (#24642)

This PR cherry-picks changes from the original PR #24632 to branch 25.1.
---
#### Original PR description
> The frontend dependency update script previously exited with an error
when deprecated packages were detected, preventing the update PR from
being created. Now the script always completes and exports the
deprecation details via GITHUB_ENV so the workflow appends them as a
warning to the commit message of the generated PR.
>

Co-authored-by: Artur Signell <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants