refactor: rename RouteParentReference to RouteReference#24602
Merged
Conversation
The record only carries a navigation target and its route parameters, so it identifies any route regardless of whether the route has a logical parent. The parent-specific name was misleading; rename it to RouteReference. RouteParentResolver and the route hierarchy APIs keep returning it.
mshabarov
previously approved these changes
Jun 15, 2026
mshabarov
approved these changes
Jun 15, 2026
|
Artur-
pushed a commit
that referenced
this pull request
Jun 15, 2026
… 25.2) (#24630) This PR cherry-picks changes from the original PR #24602 to branch 25.2. --- #### Original PR description > The record only carries a navigation target and its route parameters, so > it identifies any route regardless of whether the route has a logical > parent. The parent-specific name was misleading; rename it to > RouteReference. RouteParentResolver and the route hierarchy APIs keep > returning it. > Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com> Co-authored-by: mikhail <mikhail@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The record only carries a navigation target and its route parameters, so
it identifies any route regardless of whether the route has a logical
parent. The parent-specific name was misleading; rename it to
RouteReference. RouteParentResolver and the route hierarchy APIs keep
returning it.