test: cover gridConnector logic with WTR unit tests#9505
Open
tomivirkki wants to merge 1 commit into
Open
Conversation
tomivirkki
force-pushed
the
test/grid-connector-wtr-coverage
branch
2 times, most recently
from
7c39ec9 to
d309fa8
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tomivirkki
force-pushed
the
test/grid-connector-wtr-coverage
branch
from
d309fa8 to
458a2b8
Compare
|
vursen
reviewed
Jun 16, 2026
| describe('aria-selected', () => { | ||
| it('should remove aria-selected from rows and cells in none selection mode', async () => { | ||
| grid.$connector.setSelectionMode('NONE'); | ||
| grid.requestContentUpdate(); |
Contributor
There was a problem hiding this comment.
This shouldn't be needed, since grid.selectedItems = [] should already update the rows and cells.
Suggested change
| grid.requestContentUpdate(); |
vursen
reviewed
Jun 16, 2026
|
|
||
| it('should keep aria-selected on rows and cells in single selection mode', async () => { | ||
| grid.$connector.setSelectionMode('SINGLE'); | ||
| grid.requestContentUpdate(); |
Contributor
There was a problem hiding this comment.
Same here:
Suggested change
| grid.requestContentUpdate(); |
vursen
reviewed
Jun 16, 2026
|
|
||
| it('should prevent context menu on selection column left click', () => { | ||
| let prevented: boolean; | ||
| grid.addEventListener('click', (e) => (prevented = grid.preventContextMenu(e))); |
Contributor
There was a problem hiding this comment.
Suggested change
| grid.addEventListener('click', (e) => (prevented = grid.preventContextMenu(e))); | |
| grid.addEventListener('click', (e) => { | |
| prevented = grid.preventContextMenu(e); | |
| }); |
vursen
reviewed
Jun 16, 2026
|
|
||
| it('should not prevent context menu on regular column left click', () => { | ||
| let prevented: boolean; | ||
| grid.addEventListener('click', (e) => (prevented = grid.preventContextMenu(e))); |
Contributor
There was a problem hiding this comment.
Suggested change
| grid.addEventListener('click', (e) => (prevented = grid.preventContextMenu(e))); | |
| grid.addEventListener('click', (e) => { | |
| prevented = grid.preventContextMenu(e); | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
root.innerHTMLeven though the grid already clears cell content whenever the renderer changes, so the lines were removed as redundant.🤖 Generated with Claude Code