TypeError: subject.badge().icon is not a function

[edgeinfinity1]

This happens when I try to open the notifications sector after I gained some badges given by AutoModerator.
The rest of the notifications still loaded, but nothing about newly get badges is shown.

[Lisra-git]

#35 Should fix the issue

[edgeinfinity1]

#35 Should fix the issue

Thanks for that, I migrated mine and its now working fine.

[edgeinfinity1]

#35 Should fix the issue

Sorry to bother, but later this day after I did the same changes as the PR, I began recieving errors when using the search function:

Yes I had my flarum core and its search functions modified, but this problem never happened before. Is that my problem, or is this PR not completed yet?
Also yes, I ran npm run dev and things already.

[Lisra-git]

Will have a look asap

[Lisra-git]

Search function seem to work on my testing instance, is there any specific change you made on your search?

[edgeinfinity1]

Search function seem to work on my testing instance, is there any specific change you made on your search?

I had the View Counts plugin in my forum, so I modified this way to show the most viewed posts on top. Could that be the cause of the problem?

[edgeinfinity1]

Would it be convenient for you to merge and release this PR? Though I just looked through this plugin roughly so my understanding may be poor, I didnt see anything in PHPs defining badge a property of $userBadge. Is it possible that you made other changes on your local copy but forgot to include in this PR? I'm sorry in advance for assuming.

[Lisra-git]

Actually I don't really see how it could break your edits, the only impact is on received notification

[edgeinfinity1]

Actually I don't really see how it could break your edits, the only impact is on received notification

Could you spare some time to make a release of this patch? I want to do some further tests on where the problem could be.

[edgeinfinity1]

Well for anyone looking for solution, I found this one working:

I'm not exactly sure why this works but the PR above doesn't, but it works at least.
use together with the js changes in the PR.