Repository navigation
limits, gencerts, base58, bech32: switch to upstream btcd - #447
Merged
kcalvinalvin merged 3 commits intoOct 8, 2026
Merged
kcalvinalvin merged 3 commits into
kcalvinalvin merged 3 commits into
Conversation
The limits package is identical to btcd's. Import it from btcd, which is already a dependency, and delete the copy.
gencerts is btcd's tool with only the btcutil import path changed. Point the configuration docs at btcd's gencerts and delete the copy.
Import base58 and bech32 from btcd's address/v2 module and delete the copies. Upstream base58 returns an empty result for input containing characters above U+00FF instead of indexing past its alphabet table, and upstream bech32 exports DecodeNoLimitWithVersion. Requiring address/v2 raises secp256k1/v4 to v4.4.0, x/crypto to v0.40.0, x/sys to v0.35.0, x/text to v0.27.0, and blake256 to v1.1.0.
kcalvinalvin
force-pushed
the
2026-10-06-use-upstream-leaf-packages
branch
from
October 8, 2026 13:59
1b17060 to
5a96ca0
Compare
kcalvinalvin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import packages that match btcd's from upstream and delete the copies.
limits: identical to btcd v0.24.0, which is already a dependency.cmd/gencerts: btcd's tool with only the btcutil import path changed. The configuration docs point atgo install github.com/btcsuite/btcd/cmd/gencerts@latest.btcutil/base58,btcutil/bech32: imported from btcd'saddress/v2module. Upstream base58 returns an empty result for input containing characters above U+00FF instead of indexing past its alphabet table, and upstream bech32 exportsDecodeNoLimitWithVersion.Requiring
address/v2raisessecp256k1/v4to v4.4.0,x/cryptoto v0.40.0,x/systo v0.35.0,x/textto v0.27.0, andblake256to v1.1.0.Validation: go test -short -race ./... without the bdkwallet tag, golangci-lint run, CGO_ENABLED=0 builds for windows and darwin