This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Remove unneeded resource name which conflicts with other libraries - #208
Open
hanselip wants to merge 1 commit into
Open
Remove unneeded resource name which conflicts with other libraries#208hanselip wants to merge 1 commit into
hanselip wants to merge 1 commit into
Conversation
|
I think this would be better if the entire values-sw720dp-land folder is deleted since it will now be empty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the latest Gradle tools, we are currently unable to consume the UserVoice SDK because the activity_horizontal_margin resource in dimens.xml conflicts with another library containing the same resource name. The name conflict is likely due to this being a default resource created by Eclipse. After removing this resource and rebuilding the SDK locally, we were able to compile our app again. Given that activity_horizontal_margin does not seem to be used anywhere in the SDK, the pull request is to remove the resource altogether.