Skip to content

fix(runtime): an unset or zero radius projects square corners #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunkenInTime merged 2 commits into from
Sep 6, 2026
Merged

fix(runtime): an unset or zero radius projects square corners #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a493be
fix(runtime): an unset or zero radius projects square corners
SunkenInTime Sep 5, 2026
1c45337
Merge remote-tracking branch 'origin/master' into fix/radius-zero-def…
SunkenInTime Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion runtime/src/main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ fn buildNode(ui: *WidgetUi, model: *const Model, id: tree_mod.NodeId, is_root: b
.style = .{
.background = retained.background,
.foreground = retained.text_color,
.radius = if (retained.radius > 0) retained.radius else null,
.radius = if (retained.radius >= 0) retained.radius else null,
.border = retained.border_color,
.stroke_width = retained.border_width,
.quiet_hover = true,
Expand Down Expand Up @@ -2252,6 +2252,25 @@ test "painted row lowering preserves flex wrap on the inner layout node" {
try std.testing.expect(built.root.children[0].layout.flex_wrap);
}

test "painted boxes without a rounded utility project square corners, not the theme radius" {
var arena_state = std.heap.ArenaAllocator.init(std.testing.allocator);
defer arena_state.deinit();
var model: Model = .{};
const unset = try model.tree.createNode(.stack);
try model.tree.setBackground(unset, native_sdk.canvas.Color.rgb8(20, 30, 40));
const zero = try model.tree.createNode(.stack);
try model.tree.setBackground(zero, native_sdk.canvas.Color.rgb8(20, 30, 40));
try model.tree.setNumberProp(zero, "radius", 0);

var ui = WidgetUi.init(arena_state.allocator());
const built_unset = try ui.finalize(buildNodeForTest(&ui, &model, unset, true));
try std.testing.expectEqual(native_sdk.canvas.WidgetKind.panel, built_unset.root.kind);
try std.testing.expectEqual(@as(?f32, 0), built_unset.root.style.radius);
var zero_ui = WidgetUi.init(arena_state.allocator());
const built_zero = try zero_ui.finalize(buildNodeForTest(&zero_ui, &model, zero, true));
try std.testing.expectEqual(@as(?f32, 0), built_zero.root.style.radius);
}

test "panel lowers to a painted box around a column so children stack vertically" {
var arena_state = std.heap.ArenaAllocator.init(std.testing.allocator);
defer arena_state.deinit();
Expand Down
1 change: 1 addition & 0 deletions sdk/CONTRACT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ utility.
| `gap-N`, `gap-[Npx]` | flex gap |
| `rounded`, `rounded-{md,lg,xl,2xl,3xl,full}`, `rounded-[Npx]` | corner radius |
| `rounded-{t,r,b,l,tl,tr,br,bl}[-{md,lg,xl,2xl,3xl,full}]`, arbitrary `[Npx]` | selected corner radii; later classes win per corner |
| no `rounded-*` utility, or `rounded-[0px]` | square corners; a painted box never inherits the native theme radius |
| `border`, `border-N`, `border-[Npx]` | border width in pixels; width-only utilities default to `#E5E7EBFF` (gray-200) |
| `border-[#rgb/#rrggbb/#rrggbbaa]`, optional `/NN` alpha suffix | border color; color alone does not create width |
| `bg-`, `text-`, `border-` + Tailwind v4 named color (`red-50` through `taupe-950`, `white`, `black`, `transparent`), optional `/NN` | official v4.3.3 palette converted from OKLCH to the runtime's sRGB8 wire format; alpha multiplies the named color's alpha |
Expand Down
Loading