Adopt the shared ucgmsim/meta-ci-action workflows - #218
Open
lispandfound wants to merge 1 commit into
Open
Conversation
lint.yml (ruff, clippy, ty, deptry, numpydoc) and test.yml (pytest, coverage, cargo test) are superseded by the shared reusable workflow, which runs the same tools plus `cargo fmt --check` and `cargo test --doc`. git-extension.yml goes too, as asked: it rewrote `git+https://...` project dependencies to carry a `.git` suffix and pushed the result back as a REQUEST_CHANGES review. No project dependency is a git URL any more, so it had nothing left to check. Kept publish-PyPI.yml and wiki.yml — neither overlaps the shared workflow. The call pins @main rather than @v1: the v1 tag predates the Cargo.toml-gated Rust jobs, and this repo ships the IM._core crate under src-rust/. Per the migration notes, the one hardcoded CLI argument in the old workflows (`deptry . -ddg test,dev,types`) moves into [tool.deptry] in pyproject.toml, under the current spelling of that option, so the shared workflow can invoke deptry with no arguments. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #217 (
no_parallel). First of three.Swaps this repo's hand-rolled CI for the shared reusable workflows in
ucgmsim/meta-ci-action.Removed
lint.ymlty, deptry and numpydoc all live in the sharedci.yml.test.ymlcargo testlikewise.git-extension.ymlgit+https://…project dependencies to end in.gitand pushed the result back as aREQUEST_CHANGESreview; no dependency inpyproject.tomlis a git URL any more.publish-PyPI.ymlandwiki.ymlare untouched — neither overlaps the shared workflow.Added
.github/workflows/ci.yml— calls the sharedci.ymlwithpackage-dir: IM,uv-extra-args: "--all-extras", and the coverage gate the oldtest.ymlhad (--cov=IM,--fail-under=95)..github/workflows/claude-review.yml— the thinissue_commentwrapper for the on-demand@claude reviewbot. NeedsCLAUDE_CODE_OAUTH_TOKENset as a repo or org secret.Notes
@main, not@v1: thev1tag predates theCargo.toml-gated Rust jobs, and this repo ships theIM._corecrate undersrc-rust/.--all-extraswithout--dev:dev,testandtypesare[project.optional-dependencies]extras here, not a[dependency-groups]table, so--devwould be a no-op.deptry . -ddg test,dev,types) moves into[tool.deptry]inpyproject.toml, under the option's current non-deprecated spelling.CI will be red on this PR
That is expected and not caused by this change.
no_parallelis already red on four of its five jobs (dependencies,numpydoc,test,typecheck— see #217), and the shared workflow additionally addscargo fmt --checkandcargo test --doc, which this repo has never run. Getting all of it green is PR 2 in the stack.🤖 Generated with Claude Code