Repository navigation
feat(stovepipe): define the repair executor extension - #929
Merged
Merged
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-repair-executor
branch
2 times, most recently
from
October 23, 2026 19:01
1a474a1 to
d73907d
Compare
mnoah1
marked this pull request as ready for review
October 23, 2026 19:04
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 23, 2026 19:04
mnoah1
force-pushed
the
mnoah1/stovepipe-repair-executor
branch
2 times, most recently
from
October 23, 2026 19:34
965a1b3 to
d56cc49
Compare
mnoah1
added a commit
that referenced
this pull request
Oct 23, 2026
Summary: Add a fix controller that accepts a build ID, pages through open issues, and submits one matching issue to the configured RepairExecutor. Record submission outcomes in logs and metrics, acknowledging provider errors because acceptance may already have occurred. Add fixrequest.Publish for issue tracking to call after persistence, using a stable message identity per build. Builds on #929's executor contract. Test Plan: Run ./tool/bazel test //stovepipe/controller/fix:go_default_test //stovepipe/core/fixrequest:go_default_test //stovepipe/core/messagequeue:go_default_test --test_output=errors. Run make fmt lint check-tidy check-gazelle. Revert Plan: Revert this commit.
prathshenoy
approved these changes
Oct 23, 2026
Summary: Add RepairExecutor.Submit accepting one OpenIssue. Define queue-scoped factory resolution and submission acceptance/error semantics, with generated mocks and Bazel targets. Revert Plan: Revert this commit.
mnoah1
force-pushed
the
mnoah1/stovepipe-repair-executor
branch
from
October 23, 2026 19:45
c146174 to
cd39a5f
Compare
mnoah1
added a commit
that referenced
this pull request
Oct 23, 2026
Summary: Add a fix controller that accepts a build ID, pages through open issues, and submits one matching issue to the configured RepairExecutor. Record submission outcomes in logs and metrics, acknowledging provider errors because acceptance may already have occurred. Add fixrequest.Publish for issue tracking to call after persistence, using a stable message identity per build. Builds on #929's executor contract. Test Plan: Run ./tool/bazel test //stovepipe/controller/fix:go_default_test //stovepipe/core/fixrequest:go_default_test //stovepipe/core/messagequeue:go_default_test --test_output=errors. Run make fmt lint check-tidy check-gazelle. Revert Plan: Revert this commit.
mnoah1
enabled auto-merge
October 23, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Add a RepairExecutor contract. For now, we have a Submit method, but this contract could expand to include other functionality such as inspecting the status of a submitted request. Internally, we'll use this to submit a fix when detected.
What?
fixer.RepairExecutor.Submit(context.Context, entity.OpenIssue) (string, error).Follow-up layers will add first-failure selection, submission/history handling, and build-analysis trigger wiring.
Test Plan
make mocks gazelle.make fmt lint check-tidy check-gazelle.//stovepipe/extension/fixer:go_default_libraryand//stovepipe/extension/fixer/mock:go_default_library.Revert Plan
Revert this change.