Skip to content

feat(stovepipe): Show most broken projects first - #903

Merged
prathshenoy merged 1 commit into
mainfrom
feat/stovepipe-degree-order
Oct 23, 2026
Merged

prathshenoy merged 1 commit into
mainfrom
feat/stovepipe-degree-order

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • List newly indexed project results from most broken to least broken through the degree-ordered fact lookup, with project-only continuation tokens.
  • Preserve caller-supplied order for targeted requests and detect inconsistent indexed results.

Why:

  • Bound listing work to the requested page without historical fallback scans or sorting a non-key database attribute.

Test Plan

  • Add unit tests.
  • Verify service API and browser pagination against real services.

Revert Plan

  • Revert this PR to restore project-ID listing. Keep index maintenance and the additive table in place; authoritative facts are unchanged.

Issue Links

Stack

  1. feat(stovepipe): Add fact degree lookup table #908
  2. feat(stovepipe): Show most broken projects first #903

@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from 38ee0d7 to 4833752 Compare October 21, 2026 13:04
@prathshenoy
prathshenoy marked this pull request as draft October 21, 2026 14:58
Comment thread stovepipe/extension/storage/mysql/validation_fact_store.go Outdated
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch 2 times, most recently from 1d76e2f to feb9157 Compare October 21, 2026 19:57
@prathshenoy
prathshenoy changed the base branch from main to feat/stovepipe-project-order-index October 21, 2026 19:57
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from feb9157 to fd69b81 Compare October 21, 2026 20:42
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from fd69b81 to 50df078 Compare October 23, 2026 12:23
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from 50df078 to d498fb9 Compare October 23, 2026 12:28
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch 2 times, most recently from 64026ef to 6d61847 Compare October 23, 2026 13:03
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch 6 times, most recently from d8051a3 to f23a3c2 Compare October 23, 2026 13:27
@prathshenoy
prathshenoy added this pull request to stack #926 October 23, 2026 13:27
@prathshenoy
prathshenoy marked this pull request as ready for review October 23, 2026 13:28
@prathshenoy
prathshenoy enabled stacked auto-merge October 23, 2026 13:51
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026
Base automatically changed from feat/stovepipe-project-order-index to main October 23, 2026 15:07
@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from f23a3c2 to c0fb085 Compare October 23, 2026 15:07
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 0d00181 Oct 23, 2026
21 checks passed
@prathshenoy
prathshenoy deleted the feat/stovepipe-degree-order branch October 23, 2026 15:29
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 24, 2026
## Summary
**What**:
- Maintain a degree-ordered lookup table for project validation facts
and repair interrupted writes on retry.
- Start the lookup table empty while keeping existing project listing
and pagination unchanged.

**Why**:
- Prepare efficient severity-first reads without historical migration or
backfill tooling.

## Test Plan
- [x] Add unit tests.
- [x] Verify database writes and unchanged service and browser
pagination against real services.

## Revert Plan
- Revert dependent readers first, then this PR. Leave the additive table
in place; authoritative validation facts are unchanged.

## Issue Links
-
[CODEM-608](https://linear.app/uber/issue/CODEM-608/order-by-most-broken)

## Stack

1. uber#908
1. uber#903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants