Add `[BindMany]` to run a `[SqlUpdate]` once per item of an `IEnumerable` parameter by Copilot · Pull Request #73 · twogood/Activout.DatabaseClient

Copilot · 2026-10-12T18:19:42Z

A DAO method builds a single SqlStatement, so there is no equivalent of Dapper's ExecuteAsync(sql, IEnumerable<object>, transaction). Callers have to issue one DAO call per item.

[SqlUpdate("INSERT INTO author(isbn, name) VALUES (@isbn, @AuthorName)")]
Task<int> InsertAuthors(string isbn, [BindMany] IEnumerable<Author> authors, IDbTransaction? tx);

[BindMany] attribute
- Valid only on an IEnumerable<T> parameter of a [SqlUpdate] method.
- Each item's public properties are bound like [BindProperties]: prop and param_prop, honouring [Bind].
- All other arguments are shared by every execution, and the transaction argument is forwarded as before.
- Misuse throws NotSupportedException: non-update method, more than one [BindMany], non-enumerable type, or combined with [BindProperties].
- A null collection or a null item throws.
- The sequence is materialized when the method is called, before anything is sent to the gateway.
IDatabaseGateway.ExecuteManyAsync(statement, parameterSets)
- Returns the total affected rows.
- Breaking for custom gateways: they must implement the new method.
DapperGateway
- Runs one ExecuteAsync per parameter set in statement.Transaction.
- I did not use Dapper's list overload. It fails with "Must add values for the following parameters" when given a list of DynamicParameters.

Review notes:

Dapper matches parameter names case-sensitively, so the SQL must use @Name for a Name property. This is the same as [BindProperties] today.
The batch is not wrapped in a transaction by the library. Atomicity depends on the caller passing a transaction.
Tests cover commit and rollback with a [BindMany] insert in DapperGatewayTransactionTest. README.md has a new example.

Fixes Support batch SQL updates from IEnumerable parameter sets #62

coderabbitai · 2026-10-12T18:19:52Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 9919a14e-65b0-4ebb-92ee-88de7db78127

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Co-authored-by: twogood <189982+twogood@users.noreply.github.com>

Copilot

🟡 Changes recommended

Collection validation and runtime-type reflection violate the declared binding contract, and the README example duplicates a method.

2 open findings

What changed in this PR

Adds declarative batch execution for [SqlUpdate] DAO methods using [BindMany].

Changes:

Builds one parameter set per collection item.
Extends gateways with ExecuteManyAsync.
Adds Dapper transaction tests and documentation.

File	Description
`README.md`	Documents batch inserts.
`MethodHandler.cs`	Validates and expands `[BindMany]` arguments.
`IDatabaseGateway.cs`	Adds the batch execution contract.
`BindManyAttribute.cs`	Defines the new parameter attribute.
`DapperGatewayTransactionTest.cs`	Tests commit and rollback behavior.
`DapperGateway.cs`	Executes and totals repeated updates.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

twogood · 2026-10-12T18:28:16Z

@copilot NOT OK: "DapperGateway
Runs one ExecuteAsync per parameter set in statement.Transaction.
I did not use Dapper's list overload. It fails with "Must add values for the following parameters" when given a list of DynamicParameters."
TODO: Figure out how to use Dapper's ExecuteAsync with list:
var authors = book.Authors.Select(author => new { book.ISBN, author.AuthorName }); await connection.ExecuteAsync(authorSql, authors, transaction);

…sync Co-authored-by: twogood <189982+twogood@users.noreply.github.com>

Copilot · 2026-10-12T18:44:00Z

@copilot NOT OK: "DapperGateway
Runs one ExecuteAsync per parameter set in statement.Transaction.
I did not use Dapper's list overload. It fails with "Must add values for the following parameters" w...

Updated DapperGateway.ExecuteManyAsync in commit 2f1949b to pass parameterSets.Select(GetDynamicParameters) directly to Dapper's ExecuteAsync list overload.

Removed duplicate InsertMany method declaration. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Eriksson <david@activout.se>

…perties Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

twogood · 2026-10-23T13:55:32Z

@claude[agent] review

twogood

Three findings from my review are attached inline.

twogood · 2026-10-24T20:38:52Z

+        {
+            if (!names.Add(parameter.Name))
+            {
+                throw new NotSupportedException($"Overlapping binding '{parameter.Name}' ({_method.Name}).");


Must fix: This global duplicate check breaks existing [BindProperties] callers even when the documented parameter_property aliases make the SQL unambiguous. For example, Insert([BindProperties] User first, [BindProperties] User second) with SQL using only @first_id and @second_Name succeeds on the base commit but now throws NotSupportedException: Overlapping binding 'id'. Please remove this check from AddSqlStatementParameters; keep any new collision policy scoped to [BindMany].

twogood · 2026-10-24T20:38:52Z

+        }
+
+        var task = _gateway.ExecuteManyAsync(statement, sets);
+        return _isAsync ? task : task.Result;


Should fix: The new batch tests only declare Task<int>, while this returns the raw Task<int> for every async batch update. Please add one [BindMany] DAO method returning plain Task and assert that its rows are inserted. This covers the return form requested by #62 and guards the DispatchProxy assignability behavior.

twogood · 2026-10-24T20:38:52Z


+    // Executes the statement once per item, using the item's properties
+    [SqlUpdate("INSERT INTO user(id, name) VALUES (@id, @Name)")]
+    Task<int> InsertMany([BindMany] IEnumerable<User> users);


Should fix: Please state here that batch execution is not atomic unless the caller supplies a transaction. If item two fails after item one succeeds, item one remains committed; the example currently makes that easy to miss.

Initial plan

69b043a

Copilot AI assigned Copilot and twogood Oct 12, 2026

Copilot started work on behalf of twogood October 12, 2026 18:19

View session

Copilot AI linked an issue Oct 12, 2026 that may be closed by this pull request

Support batch SQL updates from IEnumerable parameter sets #62

Open

Apply remaining changes

f64130b

Co-authored-by: twogood <189982+twogood@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for batch SQL updates from IEnumerable parameter sets~~ Add [BindMany] to run a [SqlUpdate] once per item of an IEnumerable parameter Oct 12, 2026

Copilot finished work on behalf of twogood October 12, 2026 18:21

Copilot AI requested a review from twogood October 12, 2026 18:21

twogood requested a balanced review from Copilot October 12, 2026 18:25

Copilot started reviewing on behalf of twogood October 12, 2026 18:25

View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

Comment thread Activout.DatabaseClient/Implementation/MethodHandler.cs Outdated

Comment thread README.md Outdated

Copilot started work on behalf of twogood October 12, 2026 18:28

View session

Use Dapper's ExecuteAsync list overload in DapperGateway.ExecuteManyA…

2f1949b

…sync Co-authored-by: twogood <189982+twogood@users.noreply.github.com>

Copilot finished work on behalf of twogood October 12, 2026 18:44

twogood and others added 2 commits October 12, 2026 22:09

Remove duplicate InsertMany method from README

2916bcf

Removed duplicate InsertMany method declaration. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Eriksson <david@activout.se>

Require IEnumerable<T> for [BindMany] and bind declared item type pro…

471ef60

…perties Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

twogood requested a balanced review from Copilot October 17, 2026 15:14

Copilot AI reviewed Oct 17, 2026

twogood added 3 commits October 18, 2026 17:04

Reject overlapping BindMany parameter bindings

453a02c

Reject overlapping BindProperties parameter bindings

b03eb9a

Merge branch 'main' into copilot/support-batch-sql-updates

0c83f70

twogood marked this pull request as ready for review October 18, 2026 15:09

twogood assigned Claude Oct 23, 2026

Claude started work on behalf of twogood October 23, 2026 13:56

View session

Claude finished work on behalf of twogood October 23, 2026 13:57

twogood reviewed Oct 24, 2026

View reviewed changes

Navigation Menu

Repository navigation

Add `[BindMany]` to run a `[SqlUpdate]` once per item of an `IEnumerable` parameter - #73

Add `[BindMany]` to run a `[SqlUpdate]` once per item of an `IEnumerable` parameter#73
twogood with Copilot wants to merge 8 commits into
mainfrom
copilot/support-batch-sql-updates

Copilot AI commented Oct 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

twogood commented Oct 12, 2026

Uh oh!

Copilot AI commented Oct 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

twogood commented Oct 23, 2026

Uh oh!

twogood left a comment

Uh oh!

twogood Oct 24, 2026

Uh oh!

twogood Oct 24, 2026

Uh oh!

twogood Oct 24, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

twogood commented Oct 12, 2026

Uh oh!

Copilot AI commented Oct 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

twogood commented Oct 23, 2026

Uh oh!

twogood left a comment

Choose a reason for hiding this comment

Uh oh!

twogood Oct 24, 2026

Choose a reason for hiding this comment

Uh oh!

twogood Oct 24, 2026

Choose a reason for hiding this comment

Uh oh!

twogood Oct 24, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 12, 2026 •

edited

Loading

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading