Skip to content

Make numRecordsPerBlock configurable#477

Open
glennq wants to merge 1 commit into
twitter:masterfrom
glennq:configurable-num-records-per-block
Open

Make numRecordsPerBlock configurable#477
glennq wants to merge 1 commit into
twitter:masterfrom
glennq:configurable-num-records-per-block

Conversation

@glennq

@glennq glennq commented Feb 22, 2017

Copy link
Copy Markdown

@isnotinvain
Attempt to make numRecordsPerBlock configurable.

When testing locally there's a strange failure for pig even when building from master (at line 166 of TestThriftToPig.java):

Failed tests:   test(com.twitter.elephantbird.pig.util.TestThriftToPig): expected:<...,{(1),(2),(3)})}-{({[}),({(and a one),(and a two)}),({(then a one, two),(three!),(FOUR!!)})}-{zero={}, three={}, two={(1,Wait.),(2,What?)]}}> but was:<...,{(1),(2),(3)})}-{({[(and a one),(and a two)}),({}),({(then a one, two),(three!),(FOUR!!)})}-{zero={}, two={(1,Wait.),(2,What?)}, three={]}}>

Passed all tests before this failure.

@CLAassistant

CLAassistant commented Jul 18, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jiyuan Qian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants