Skip to content

Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3#310

Open
ddaniels wants to merge 4 commits into
twitter:masterfrom
mortardata:master
Open

Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3#310
ddaniels wants to merge 4 commits into
twitter:masterfrom
mortardata:master

Conversation

@ddaniels

@ddaniels ddaniels commented May 6, 2013

Copy link
Copy Markdown

Fixes issue #309.

Doug Daniels and others added 2 commits May 3, 2013 17:18
Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default should be 0.

btw, we can avoid this getFileStatus() call entirely. The output stream can keep track of number of bytes written or just not even bother deleting index file for small lzo files (with a config).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of those sound good. Which would you prefer?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping track of number of bytes written sounds best.. (not sure sure what S3 does when you delete file before it actually 'appears').

Otherwise, you could set the default based on filesystem (20 for S3 and 0 for others).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'm going to close this pull request and open a new one with the bytes written strategy.

Doug Daniels added 2 commits June 21, 2013 15:57
Ensure any output written is fully cleaned up to prevent downstream retry tasks from failing
@CLAassistant

CLAassistant commented Jul 18, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Doug Daniels
❌ MarkRoddy


Doug Daniels seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants