Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3#310
Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3#310ddaniels wants to merge 4 commits into
Conversation
…ue to eventual consistency in S3
Retry file status (ls) operations, which can fail with FileNotFound due to eventual consistency in S3
There was a problem hiding this comment.
I think the default should be 0.
btw, we can avoid this getFileStatus() call entirely. The output stream can keep track of number of bytes written or just not even bother deleting index file for small lzo files (with a config).
There was a problem hiding this comment.
Any of those sound good. Which would you prefer?
There was a problem hiding this comment.
Keeping track of number of bytes written sounds best.. (not sure sure what S3 does when you delete file before it actually 'appears').
Otherwise, you could set the default based on filesystem (20 for S3 and 0 for others).
There was a problem hiding this comment.
Sounds good. I'm going to close this pull request and open a new one with the bytes written strategy.
…etry tasks from failing
Ensure any output written is fully cleaned up to prevent downstream retry tasks from failing
|
Doug Daniels seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Fixes issue #309.