Repository navigation
chore: keep the fetch-deps archive out of the checkout - #91
Merged
Merged
Conversation
Downloads go to a temporary directory under the OS temp dir, removed on success and failure. A local archive is extracted in place and never deleted; one inside deps/ is refused, since deps/ is cleared first.
luisrivas
changed the title
charliesantos
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run fetch-depsdownloads the native dependency archive to the OS temp dir instead of the checkout root, and removes it when the run ends. In thedocker/run.shcontainer this keeps the download off the bind-mounted host checkout.Pull Request Details
Description
RTC_CPP_ARCHIVEor--twilio-video-pkg) is extracted in place, not copied, and never deleted. An archive insidedeps/is refused, sincedeps/is cleared before extraction.tarruns without a shell, so archive paths with shell characters work.Public API changes
None.
scripts/is not part of the published package.Burndown
Before review
CHANGELOG.mdunder the unreleased heading if the change is user-visiblenpm run lintandnpm test