Repository navigation
chore: mount rtc-cpp in the dev container only when it is checked out - #89
Merged
Merged
Conversation
charliesantos
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/run.shnow mounts../rtc-cpponly when that checkout exists, so the dev container starts without it. The default build fetches the prebuilt rtc-cpp; only a source build needs the mount.Pull Request Details
Description
Mounts
../rtc-cppat/opt/twilio/rtc-cpponly when the directory exists, and documents this inDEVELOPER_GUIDE.md.Public API changes
None
Burndown
Before review
CHANGELOG.mdunder the unreleased heading if the change is user-visiblenpm run lintandnpm test