Repository navigation
Run ABI floor, Node 26 and customer image checks on every PR - #85
Merged
Merged
Conversation
Move the DT_NEEDED and ABI floor checks into scripts/check-linux-abi.sh and run them in CI as well as at release. Rerun the unit tests on Node 26 against the addon built on Node 24, and load the built package in supported and unsupported Linux images.
charliesantos
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the glibc/libstdc++ ABI floor and DT_NEEDED checks on every PR, rerun the unit tests on Node 26, and load the built package in supported and unsupported Linux images.
Pull Request Details
Description
scripts/check-linux-abi.shholds the DT_NEEDED and ABI floor checks that were inline inrelease.yml.release.ymlcalls it, andci.ymlruns it on the Linux build, so a change that moves the documented floors fails on the PR instead of at release.ci.ymlrerunsnpm run test:uniton Node 26.13 against the addon built on Node 24.ci.ymlloads the built package in images pinned by digest:node:26-slimandnode:24-trixie-slimmust load,node:24must fail withUnsupportedPlatformError, andnode:26-alpinemust fail withNativeBindingLoadError.Public API changes
None.
Burndown
Before review
CHANGELOG.mdunder the unreleased heading if the change is user-visiblenpm run lint,npm run format:checkandnpm run test:unit