Skip to content

ci: drop linked-versions and web from release-please config#186

Merged
twangodev merged 1 commit intomainfrom
ci/release-please-slim-config
May 10, 2026
Merged

ci: drop linked-versions and web from release-please config#186
twangodev merged 1 commit intomainfrom
ci/release-please-slim-config

Conversation

@twangodev
Copy link
Copy Markdown
Owner

@twangodev twangodev commented May 9, 2026

Follow-up to #184. SDK and rust crate no longer share a version (independent semver), and web is no longer a release-please component — its ogis dep uses "*" instead. Rust uses include-component-in-tag: false so existing vX.Y.Z tags still apply. A backfill tag ogis-typescript-v0.2.0 pointing at v0.2.0's commit (ad63aaa) is needed before merging so release-please sees the correct typescript boundary.

Summary by CodeRabbit

  • Chores
    • Updated release configuration by removing a package entry and simplifying plugin settings.
    • Adjusted internal dependency version specification for improved flexibility.

Review Change Stack

Follow-up to the previous multi-component switch. Two changes:

1. Drop `linked-versions` and `web` from the release-please config.
   The SDK doesn't need to share a version with the Rust crate — they
   evolve at different paces, and a service-side refactor shouldn't
   force an SDK release. Without `linked-versions`, each component
   bumps based on its own conventional commits.

2. Set `"ogis": "*"` in `web/package.json` instead of registering
   `web` as a release-please component. `web` is private and never
   published; it only consumed the typescript workspace via a
   versioned range, which broke on the typescript major bump. With
   `"*"` the range matches any local workspace version forever.

Add `"include-component-in-tag": false` to the Rust component so it
keeps tagging as `vX.Y.Z` (matching the existing `v0.1.0`…`v0.2.0`
history) instead of `ogis-vX.Y.Z`. This avoids a tag backfill for
the Rust crate.

`node-workspace` still updates the root `package-lock.json` whenever
the typescript package version changes, since `packages/typescript`
remains a configured node component.

Note: `ogis-typescript-v0.2.0` tag still needs to be backfilled
pointing at v0.2.0's commit (ad63aaa) so release-please uses the
correct boundary for the typescript component.
Copilot AI review requested due to automatic review settings May 9, 2026 22:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

📝 Walkthrough

Walkthrough

The PR removes the web package from release-please tracking by deleting its manifest entry and configuration section, consolidates root package release settings with explicit component naming and component-tag exclusion, simplifies plugin configuration, and updates the web package's ogis dependency to use a flexible wildcard version constraint.

Changes

Release Configuration Simplification

Layer / File(s) Summary
Version Manifest Removal
.release-please-manifest.json
The "web": "0.0.1" entry is removed from the manifest while root and typescript package versions remain at 0.2.0.
Release Configuration Consolidation
release-please-config.json
Root package component is explicitly set to "ogis" with include-component-in-tag: false; the separate web package configuration is removed; plugins are simplified from a multi-plugin setup with linked-versions to only node-workspace.
Web Package Dependency
web/package.json
The ogis dependency constraint is changed from ^0.2.0 to * for flexible version consumption.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • twangodev/ogis#173: Modifies the same release-please configuration and manifest files, removing the web package from separate release tracking.
  • twangodev/ogis#121: Related changes to release-please configuration and manifest files affecting the root package and version entries.

Poem

🐰 A manifest cleansed, the web package freed,
Release-please streamlined, no linked-versions' greed,
Wildcard versions bloom, dependency chains grow light,
With ogis consolidated, the config feels just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing linked-versions and the web component from the release-please configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/release-please-slim-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 26.75% <ø> (ø)
typescript 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
release-please-config.json (1)

1-15: ⚡ Quick win

Verify backfill tag creation before merge.

According to the PR objectives, you must create the backfill tag ogis-typescript-v0.2.0 pointing at commit ad63aaa before merging. This ensures release-please recognizes the correct TypeScript component boundary for future releases.

#!/bin/bash
# Check if the required backfill tag exists
git tag -l "ogis-typescript-v0.2.0"

# If tag exists, verify it points to the expected commit
if git rev-parse ogis-typescript-v0.2.0 >/dev/null 2>&1; then
  echo "Tag exists at commit:"
  git rev-parse ogis-typescript-v0.2.0
  echo "Expected commit: ad63aaa"
else
  echo "WARNING: Backfill tag ogis-typescript-v0.2.0 does not exist yet"
fi
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@release-please-config.json` around lines 1 - 15, Before merging, create the
backfill Git tag ogis-typescript-v0.2.0 and point it at commit ad63aaa so
release-please can detect the TypeScript component boundary for the
"ogis-typescript" package in release-please-config.json; verify the tag exists
and resolves to ad63aaa (or create it and push it to remote) to ensure future
releases for the "packages/typescript" component are generated correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@release-please-config.json`:
- Around line 1-15: Before merging, create the backfill Git tag
ogis-typescript-v0.2.0 and point it at commit ad63aaa so release-please can
detect the TypeScript component boundary for the "ogis-typescript" package in
release-please-config.json; verify the tag exists and resolves to ad63aaa (or
create it and push it to remote) to ensure future releases for the
"packages/typescript" component are generated correctly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1530f86c-a94e-4783-9ef9-a22d2a12eb59

📥 Commits

Reviewing files that changed from the base of the PR and between bf2eb6d and 334a4c5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .release-please-manifest.json
  • release-please-config.json
  • web/package.json

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monorepo’s release automation to support independent versioning between the Rust crate and the TypeScript SDK, and removes web as a release-please managed component.

Changes:

  • Adjust release-please config to remove linked-versions and the web package, and keep Rust tags as vX.Y.Z via include-component-in-tag: false.
  • Update web to depend on the ogis TypeScript SDK with a wildcard ("*").
  • Remove web from the release-please manifest and update the root lockfile accordingly.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
web/package.json Changes the ogis dependency version range to *.
release-please-config.json Removes web + linked-versions plugin; updates tagging config for Rust; changes plugin configuration format.
package-lock.json Updates locked workspace dependency metadata to reflect ogis: "*".
.release-please-manifest.json Removes web entry so release-please no longer tracks it as a component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web/package.json
Comment thread release-please-config.json
@twangodev twangodev merged commit a51f7e4 into main May 10, 2026
35 checks passed
@twangodev twangodev deleted the ci/release-please-slim-config branch May 10, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants