ci: drop linked-versions and web from release-please config#186
ci: drop linked-versions and web from release-please config#186
Conversation
Follow-up to the previous multi-component switch. Two changes: 1. Drop `linked-versions` and `web` from the release-please config. The SDK doesn't need to share a version with the Rust crate — they evolve at different paces, and a service-side refactor shouldn't force an SDK release. Without `linked-versions`, each component bumps based on its own conventional commits. 2. Set `"ogis": "*"` in `web/package.json` instead of registering `web` as a release-please component. `web` is private and never published; it only consumed the typescript workspace via a versioned range, which broke on the typescript major bump. With `"*"` the range matches any local workspace version forever. Add `"include-component-in-tag": false` to the Rust component so it keeps tagging as `vX.Y.Z` (matching the existing `v0.1.0`…`v0.2.0` history) instead of `ogis-vX.Y.Z`. This avoids a tag backfill for the Rust crate. `node-workspace` still updates the root `package-lock.json` whenever the typescript package version changes, since `packages/typescript` remains a configured node component. Note: `ogis-typescript-v0.2.0` tag still needs to be backfilled pointing at v0.2.0's commit (ad63aaa) so release-please uses the correct boundary for the typescript component.
📝 WalkthroughWalkthroughThe PR removes the ChangesRelease Configuration Simplification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
release-please-config.json (1)
1-15: ⚡ Quick winVerify backfill tag creation before merge.
According to the PR objectives, you must create the backfill tag
ogis-typescript-v0.2.0pointing at commitad63aaabefore merging. This ensures release-please recognizes the correct TypeScript component boundary for future releases.#!/bin/bash # Check if the required backfill tag exists git tag -l "ogis-typescript-v0.2.0" # If tag exists, verify it points to the expected commit if git rev-parse ogis-typescript-v0.2.0 >/dev/null 2>&1; then echo "Tag exists at commit:" git rev-parse ogis-typescript-v0.2.0 echo "Expected commit: ad63aaa" else echo "WARNING: Backfill tag ogis-typescript-v0.2.0 does not exist yet" fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@release-please-config.json` around lines 1 - 15, Before merging, create the backfill Git tag ogis-typescript-v0.2.0 and point it at commit ad63aaa so release-please can detect the TypeScript component boundary for the "ogis-typescript" package in release-please-config.json; verify the tag exists and resolves to ad63aaa (or create it and push it to remote) to ensure future releases for the "packages/typescript" component are generated correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@release-please-config.json`:
- Around line 1-15: Before merging, create the backfill Git tag
ogis-typescript-v0.2.0 and point it at commit ad63aaa so release-please can
detect the TypeScript component boundary for the "ogis-typescript" package in
release-please-config.json; verify the tag exists and resolves to ad63aaa (or
create it and push it to remote) to ensure future releases for the
"packages/typescript" component are generated correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1530f86c-a94e-4783-9ef9-a22d2a12eb59
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.release-please-manifest.jsonrelease-please-config.jsonweb/package.json
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s release automation to support independent versioning between the Rust crate and the TypeScript SDK, and removes web as a release-please managed component.
Changes:
- Adjust release-please config to remove
linked-versionsand thewebpackage, and keep Rust tags asvX.Y.Zviainclude-component-in-tag: false. - Update
webto depend on theogisTypeScript SDK with a wildcard ("*"). - Remove
webfrom the release-please manifest and update the root lockfile accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
web/package.json |
Changes the ogis dependency version range to *. |
release-please-config.json |
Removes web + linked-versions plugin; updates tagging config for Rust; changes plugin configuration format. |
package-lock.json |
Updates locked workspace dependency metadata to reflect ogis: "*". |
.release-please-manifest.json |
Removes web entry so release-please no longer tracks it as a component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow-up to #184. SDK and rust crate no longer share a version (independent semver), and
webis no longer a release-please component — itsogisdep uses"*"instead. Rust usesinclude-component-in-tag: falseso existingvX.Y.Ztags still apply. A backfill tagogis-typescript-v0.2.0pointing at v0.2.0's commit (ad63aaa) is needed before merging so release-please sees the correct typescript boundary.Summary by CodeRabbit