Implement setMinPINLength command, minPinLength extension and alwaysUv feature#59
Merged
Conversation
Closed
Contributor
|
Tasks in ac2443e After further investigation I agree (and implemented) storing the len. |
c5a6686 to
c667916
Compare
…edential (§10.1.2.1)
…ull implementation
…PIN under forcePINChange + align setPin/getPinToken error codes Fixes: #43
16c44ac to
a7e869b
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is cherry-picked from #54.
To do:
datainauthenticator_confignew_value === self.min_pin_length()correctly inPersistentState::set_min_pin_length(no error, but also no unnecessary write)forceChangePininconfig_set_min_pin_lengthforce_pin_changeinPersistentState::set_pinif the hash has not changedTo decide:
Follow-up:
cc @0x0ece