fix: preserve active firmware image URL when API keys are enabled#863
Merged
Conversation
The device update page was replacing the firmware-reported image URL with a generated HTTP /next URL whenever RequireAPIKey was enabled. That meant devices currently using WebSocket URLs could get pushed back to HTTP after syncing firmware settings or running an OTA flow. Keep the URL reported by the device and only append the API key to it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe device update page now preserves the existing firmware image URL when API-key protection is enabled and appends the device API key instead of regenerating the URL. ChangesDevice update rendering
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device update page was replacing the firmware-reported image URL with a generated HTTP
/nextURL wheneverRequireAPIKeywas enabled. That meant devices currently using WebSocket URLs could get pushed back to HTTP after syncing firmware settings or running an OTA update.This fix keeps the URL reported by the device and only append the API key to it.
Summary by CodeRabbit