Conversation
Find package version on-demand
`rtcIntersect1` fills the `RTCHit` fields only when a ray actually hits something, and the `RTCRayHit` struct is reused for every ray in the batch. A ray that missed therefore reported `u`, `v` and `Ng` belonging to whichever earlier ray hit something last, so a miss looked like it had landed on a real surface. Only the ID fields were being reset, which is why `primID`/`geomID` were already correct and this went unnoticed: callers that filter on `geomID >= 0` never saw it. It also made a ray's result depend on the other rays in its batch. Report zeros for `u`, `v` and `Ng` on a miss instead. `tfar` is unchanged: Embree leaves it at the caller's input distance, which is already meaningful. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix: clear hit attributes on rays that miss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.post1