Repository navigation
fix: restore automatic issue intake and coor lease renewal - #16
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2c6352ad8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initial GitHub issue backlog polling sent an epoch date filter and returned no issues in
erden-godot. After intake recovery, busy coor processing also let its 90-second lease expire and the hook blocked even status/disable. Version 1.2.1 repairs intake, bounded lease renewal and safe owner controls. Coor keeps its foreground wait active and distinguishes the local queue from GitHub issue counts.Evidence
tourbut/erden-godotAPI query with the epoch date filter returned[]while issues feat: FullOps 0.3.1 공통 개발 규칙과 회귀 검사 추가 #1/보드 산출물 선택 시 설계서 등 원천 문서를 열람할 수 있도록 지원 #4 were open. The new regression failed on the original source.After: no-date query returns all five issues, including open feat: FullOps 0.3.1 공통 개발 규칙과 회귀 검사 추가 #1/보드 산출물 선택 시 설계서 등 원천 문서를 열람할 수 있도록 지원 #4. The full issue-mode regression and six update checks pass, covering initial and subsequent query paths. Generated distribution matches source; final required CI validates packaging and portability.
After: reactivation advances both the cursor and creation cutoff, preserving existing jobs while rejecting old issues with recent updates and accepting new issues. The issue-mode suite passes.
pollonce using its existing lease, then continue its foregroundwait. The old watcher reads the advanced cursor on its next poll. No impersonation, alternate coordinator, credential changes, or queue-state rewrites are needed.After: watcher renewal reuses wait's identity/fencing checks. Native renewal never exceeds the last terminal activity plus 90 seconds; stale/missing/future activity cannot extend it. Owner status/disable accepts only the trusted Python script and exact command form. Lease, incarnation and command-spoofing regressions pass.
--not-dispatchedafter auditing its receipts and termination. This requires no local dispatch intent and an explicitly empty complete task/worker listing; it preserves the attempt/history and requires a fresh owner receipt. Default absent-task reconciliation still rejects inference from absence alone. The restart path and rejection of dispatch intent/unknown fleet are covered.Merge Danger
Door: two-way.
Blast Radius: automation. The first approved backlog scan reads the full existing issue list; pagination, author allowlist, duplicate prevention, lease validation and draft-PR scope are preserved. New-issues-only reactivation advances its cutoff. Independent renewal requires current identity and bounded activity, never revives expired leases, and preserves SessionEnd fencing. Installation does not enable automatic mode. Existing Codex sessions need a safe stop, plugin update and explicitly enabled fresh session for the complete fix.