Repository navigation
docs: finish issue 8 render verification and editable handoff - #14
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcfbd53cd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the remaining development verification for #8 with fresh Windows renders and an editable handoff. The earlier Linux evidence remains unchanged. Human listening and aesthetic acceptance are explicitly
not_run.Evidence
Before: the original media was unavailable on this host, Remotion's older color contract was invalid, and forced interruption was unverified.
After: both engines pass actual BT.709/TV, 30fps cadence, dimensions/duration/frame counts and planned audio comparison. Killing a render during capture preserves v04; a fresh installation in a second path produces v06 with matching nine sampled decoded RGB frames. A local approved WAV can now be supplied to the development asset preparer.
Evidence:
docs/evidence/motion-issue8-windows.json; persistent source, assets, videos and logs:.local/motion-issue8-final/. No paid media API, cloud rendering, telemetry upload or global PATH changes. Failure attempts remain preserved.Merge Danger
Door: two-way. Blast radius: development example and verification documentation; portable plugin/runtime and standard setup dependencies are unchanged. Media binaries remain in the persistent local handoff folder. SAPI speech quality and commercial eligibility are not asserted; user listening/aesthetic acceptance remains separate.
Closes #8