Say why triage acknowledge writes nothing, instead of promising it will

[yh928]

Summary

The Acknowledge arm of triage::escalation::apply_decision logged memory-write is a future addition. That described an unimplemented plan rather than the behaviour — and the plan was wrong. Replaces it with the reason the arm writes nothing, improves the log line, and files the work that note was actually pointing at.

Problem

Three things, in order of how much they matter.

The planned write would have been a bug. Copying an acknowledged trigger's summary into the memory store duplicates a document the connector sync has already ingested — the same mail, a second copy, competing with extracted memories for the same recall slots. That is #5312; #5315 is the fix for the copies that already exist. A note inviting the next contributor to add another one is worse than no note.

The arm's real behaviour was undocumented. Acknowledge is a classification, and the two things worth keeping are already kept elsewhere:

	where	when
what the trigger was	trigger_history daily JSONL	written before the triage gates, so it survives even with triage disabled
what it was judged to be	DomainEvent::TriggerEvaluated	published for every action, a few lines above this arm

Neither is obvious from the arm, so "writes nothing" read as an omission rather than a decision.

The log said what was missing instead of what happened. A reader tailing logs for an acknowledged trigger got a parenthetical about future work and no statement of the outcome.

Solution

• The comment now states why the arm writes nothing, and names the two records that already exist.
• The log line states what happened and where to look, and carries source and card_linked alongside the existing fields.
• The sibling DROP arm gets the same two fields. Both are "no downstream work" verdicts; a dashboard filtering on source= would otherwise silently see only half of them.
• The genuinely-missing piece — a record of what happened after the verdict, for every action rather than this one — is filed as Record what a trigger's verdict actually led to #5408 and referenced from the comment, so the next reader finds the work instead of re-deriving the note.

No behaviour change: the arm wrote nothing before and writes nothing now.

Acceptance criteria

• The misleading note is gone — replaced by the reason, not by silence.
• The reason is checkable — the comment names trigger_history and TriggerEvaluated, both verifiable in the same file's call path.
• The follow-up is findable — Record what a trigger's verdict actually led to #5408 is linked from the code, not only from this PR.
• Sibling arms stay greppable together — DROP and ACKNOWLEDGE carry the same field set.
• Tests pass — agent::triage 70 tests; cargo check --lib --all-features clean.

Related

• Record what a trigger's verdict actually led to #5408 — record what a trigger's verdict actually led to (what the removed note was reaching for).
• Surface background work in the app so a user can watch it and take it over #5409 — surface background work in the app; renders Record what a trigger's verdict actually led to #5408.
• Internal agents store their own prompts as the user's conversation memories #5312 / fix(memory): stop copying the conversation into memory; let recall answer with memories #5315 — why writing the input to memory a second time is the wrong move.

Summary by CodeRabbit

• New Features
  • Improved drop and acknowledgment activity logs with trigger source and task-card details.
  • Clarified acknowledgment records to indicate whether trigger history is retained, whether only the evaluation result is retained, and that no memory entry was created.
  • Added clearer activity history for Composio-triggered acknowledgments and other trigger sources, including their differing retention behavior.

[greptile-apps]

yh928 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b590b36-f95d-4838-b3e1-9ad15a62c5d6

📥 Commits

Reviewing files that changed from the base of the PR and between c82715b and 14028cf.

📒 Files selected for processing (1)

• src/openhuman/agent/triage/escalation.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• src/openhuman/agent/triage/escalation.rs

---

📝 Walkthrough

Walkthrough

The escalation logic updates drop and acknowledge logs with trigger source and task-card linkage. Acknowledge handling reports source-specific input retention, performs no memory write, and records evaluation through TriggerEvaluated.

Changes

Triage decision logging

Layer / File(s)	Summary
Drop and acknowledge decision logging src/openhuman/agent/triage/escalation.rs	Drop and acknowledge logs include trigger source and task-card linkage. Acknowledge handling documents no memory write, reports Composio trigger-history retention, and reports verdict-only retention for other sources. Tests cover Composio, webhook, cron, and webview sources.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit, logging hops with care,
Sources and task cards now join the air.
No memory write when acknowledge is near,
Retention notes make records clear.
TriggerEvaluated marks the way,
Drop and ack logs shine today.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: explain why triage acknowledge writes nothing instead of promising a future write.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/openhuman/agent/triage/escalation.rs`:
- Around line 69-88: Update the acknowledge logging in apply_decision to
describe durable retention based on envelope.source. Keep the trigger-history
retention statement only for composio sources, and provide source-appropriate
wording for webhook, cron, and external envelopes while preserving the existing
structured fields and no-action behavior.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 156d8dd5-d34c-48e4-86d9-b1f0e17a86a0

📥 Commits

Reviewing files that changed from the base of the PR and between d9d03af and e0cd845.

📒 Files selected for processing (1)

• src/openhuman/agent/triage/escalation.rs

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[tinysweeper]

tinysweeper found nothing blocking. Approving.

             $0.0021 · 16,131 in / 5,221 out · 3,567 cached (22%) · z-ai/glm-5.2
critique:    $0.0010 · 5,484 in  / 3,168 out · 896 cached (16%)   · z-ai/glm-5.2
security:    $0.0001 · 3,338 in  / 24 out    · 2,671 cached (80%) · z-ai/glm-5.2
tests:       $0.0005 · 3,253 in  / 1,044 out · 0 cached (0%)      · z-ai/glm-5.2
description: $0.0005 · 4,056 in  / 985 out   · 0 cached (0%)      · z-ai/glm-5.2

[coderabbitai]

🧹 Nitpick comments (1)

src/openhuman/agent/triage/escalation.rs (1)

799-813: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover TriggerSource::External in this regression test.

TriggerSource supports External, but this loop covers only Composio, webhook, cron, and webview. Add an External case and assert none — verdict only. The current wildcard returns the expected value, but the test does not protect this supported source from a future regression.

Proposed test addition

             TriggerSource::WebviewIntegration {
                 provider: "gmail".into(),
                 account_id: "a".into(),
             },
+            TriggerSource::External {
+                caller_id: "caller".into(),
+                reason: "reason".into(),
+            },

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/openhuman/agent/triage/escalation.rs` around lines 799 - 813, Add a
TriggerSource::External case to the regression-test loop alongside the existing
source variants, using the appropriate External fields, and assert that it
produces no action (“none”) with only the verdict. Keep the existing assertions
and wildcard behavior unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/openhuman/agent/triage/escalation.rs`:
- Around line 799-813: Add a TriggerSource::External case to the regression-test
loop alongside the existing source variants, using the appropriate External
fields, and assert that it produces no action (“none”) with only the verdict.
Keep the existing assertions and wildcard behavior unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 141361fd-33d2-4dc7-bada-666e850eb122

📥 Commits

Reviewing files that changed from the base of the PR and between 8774fe4 and a994ca3.

📒 Files selected for processing (1)

• src/openhuman/agent/triage/escalation.rs

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.