feat: support proxy environment variables for OAuth requests#999
Open
florianilch wants to merge 1 commit into
Open
feat: support proxy environment variables for OAuth requests#999florianilch wants to merge 1 commit into
florianilch wants to merge 1 commit into
Conversation
Configure the OAuth HTTP transport with http.ProxyFromEnvironment so token exchange and userinfo requests respect HTTP_PROXY, HTTPS_PROXY and NO_PROXY.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe OAuth service configures its internal HTTP transport with ChangesOAuth proxy support
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OAuth service currently uses a custom
http.Transportto configure TLS.This change configures that transport to use also
http.ProxyFromEnvironmentto enableHTTP_PROXY,HTTPS_PROXYandNO_PROXYfor token exchange and userinfo requests. The existing TLS configuration and other transport behavior remain unchanged.Closes #998
Verification
make webui testand manual testSummary by CodeRabbit