feat(cuda): GPU-native fused filtered sampling & lazy host KV materialization - #673
Open
karan68 wants to merge 14 commits into
Open
feat(cuda): GPU-native fused filtered sampling & lazy host KV materialization#673karan68 wants to merge 14 commits into
karan68 wants to merge 14 commits into
Conversation
…ent CUDA decode - Add to_q8_0_bytes on Q8_0PackedRows4 to allow bit-exact reconstruction of GGUF Q8_0 bytes on demand without retaining duplicate raw blocks in host RAM. - Add CpuTensor::q8_0_raw_bytes and update resident CUDA engine raw extraction to return Cow<[u8]>. - Preserve q8_0_blocks.is_none() invariant when PackedRows4 is loaded, ensuring all tensor_store memory tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a major throughput bottleneck during non-greedy sampling on CUDA and eliminates redundant synchronous host memory copies during prompt prefill:
GPU-Native Fused Filtered Sampling:
Lazy Host KV Materialization on GPU Prefill:
Platform Repack Safety:
Verification & Benchmarks