Skip to content

[BugFix][Arith] Fold float Min/Max commutatively on NaN #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sohampanda000 wants to merge 1 commit into
base: tilelang_main
Choose a base branch
from
Open

[BugFix][Arith] Fold float Min/Max commutatively on NaN #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/arith/const_fold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ inline ffi::Optional<PrimExpr> TryConstFold<tirx::Min>(PrimExpr a, PrimExpr b) {
TVM_ARITH_CONST_PROPAGATION({
const DataType& rtype = a.dtype();
if (pa && pb) return IntImm(rtype, std::min(pa->value, pb->value));
if (fa && fb) return FloatImm(rtype, std::min(fa->value, fb->value));
if (fa && fb) return FloatImm(rtype, std::fmin(fa->value, fb->value));
Comment on lines 332 to +333
});
if (a.same_as(b)) return a;
return std::nullopt;
Expand All @@ -341,7 +341,7 @@ inline ffi::Optional<PrimExpr> TryConstFold<tirx::Max>(PrimExpr a, PrimExpr b) {
TVM_ARITH_CONST_PROPAGATION({
const DataType& rtype = a.dtype();
if (pa && pb) return IntImm(rtype, std::max(pa->value, pb->value));
if (fa && fb) return FloatImm(rtype, std::max(fa->value, fb->value));
if (fa && fb) return FloatImm(rtype, std::fmax(fa->value, fb->value));
Comment on lines 343 to +344
});
if (a.same_as(b)) return a;
return std::nullopt;
Expand Down