Skip to content

[Doc][Attention] Clarify dense GQA input-inferred contract - #1994

Merged
lcy-seso merged 1 commit into
tile-ai:mainfrom
superAngGao:refactor/attention/gqa-dense-static-geometry
Aug 31, 2026
Merged

lcy-seso merged 1 commit into
tile-ai:mainfrom
superAngGao:refactor/attention/gqa-dense-static-geometry

Conversation

@superAngGao

@superAngGao superAngGao commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • document that Dense GQA derives B, Sq, Skv, H, Hkv, D, and input dtype from every forward call
  • separate construction-time attention semantics from call-time tensor metadata
  • define the full computation: FP8 dequantization, optional RoPE, scaled QK, softcap, causal/window masking, softmax, and PV reduction
  • map every constructor parameter to its effect in the equations
  • clarify that one Op instance may resolve and cache implementations for multiple input shapes

Scope

This draft does not change the constructor, forward signature, manifest, validation, dispatch, or kernels. It only clarifies the input-inferred contract established in #1975, following the documentation structure used by GemmFwdOp.

Validation

  • python -m py_compile src/tileops/ops/attention/gqa.py
  • python -m ruff check src/tileops/ops/attention/gqa.py
  • PYTHONUTF8=1 python scripts/lint/op_docstrings_lint.py
  • git diff --check

@github-actions github-actions Bot added the refactor Code restructuring without behavior change label Aug 27, 2026
@superAngGao
superAngGao force-pushed the refactor/attention/gqa-dense-static-geometry branch from 4783ea2 to 6b5e705 Compare August 28, 2026 12:16
@superAngGao superAngGao changed the title [Refactor][Attention] Fix dense GQA model geometry at construction [Docs][Attention] Clarify dense GQA input-inferred contract Aug 28, 2026
@superAngGao
superAngGao force-pushed the refactor/attention/gqa-dense-static-geometry branch 4 times, most recently from 4cb6339 to 968c7b9 Compare August 31, 2026 02:33
@superAngGao superAngGao changed the title [Docs][Attention] Clarify dense GQA input-inferred contract [Doc][Attention] Clarify dense GQA input-inferred contract Aug 31, 2026
@superAngGao
superAngGao force-pushed the refactor/attention/gqa-dense-static-geometry branch from 968c7b9 to 1282f4b Compare August 31, 2026 02:34
@superAngGao
superAngGao marked this pull request as ready for review August 31, 2026 02:35
@superAngGao
superAngGao requested review from a team and lcy-seso August 31, 2026 02:35
@lcy-seso
lcy-seso merged commit 38b7cdc into tile-ai:main Aug 31, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code restructuring without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants