Skip to content

build(typegen): generate TS bindings via xtask instead of the CLI#285

Open
thwbh wants to merge 2 commits into
developfrom
282-feature-config-driven-android-signing-without-regenerating-genandroid-in-ci
Open

build(typegen): generate TS bindings via xtask instead of the CLI#285
thwbh wants to merge 2 commits into
developfrom
282-feature-config-driven-android-signing-without-regenerating-genandroid-in-ci

Conversation

@thwbh

@thwbh thwbh commented Jun 17, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chrome-grid chrome-grid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟪🔷 netrunner jacked 1 patch straight into the diff — hit Apply suggestion to commit, choom.

Comment thread src-tauri/xtask/src/main.rs
@chrome-grid

chrome-grid Bot commented Jun 17, 2026

Copy link
Copy Markdown

🟪🔷 netrunner :: intrusion report

░▒▓ N E T R U N N E R ▓▒░
   🟪 GRID STATUS: JACKED IN   |   netrunner-review: pass

The PR replaces the CLI-based TypeScript binding generation with an xtask-based approach. CI is green, and the implementation looks solid. The change improves maintainability by centralizing the typegen version in the workspace.


📡 NETWATCH · gate checks

codecov/patchsuccess
Run vitestsuccess
Run nextestsuccess
Convention & traceability gatesuccess
syncskipped
automergeskipped
Rust Security Auditsuccess
dependency-reviewsuccess
npm Security Auditsuccess

☠️ GLITCH TRACE · flaws & patches

⚪ TRACE · src-tauri/xtask/src/main.rs — The comment in main.rs mentions that the scaffold is not yet wired into beforeBuildCommand / build.rs, but the PR actually does wire it into beforeBuildCommand. This comment should be updated or removed.

🩹 patch: suggested inline — hit Apply suggestion on the diff ↘

🟢 VERDICT // JACKED IN — deck's clean, netrunner-review gate open.

"Looks solid, choom. Your chrome's polished and the ICE is thin — keep riding the data streams."
netrunner 🟪🔷

verdict: APPROVE · model: mistral-medium-2508

@chrome-grid

chrome-grid Bot commented Jun 17, 2026

Copy link
Copy Markdown

🟪🔷 netrunner :: intrusion report

░▒▓ N E T R U N N E R ▓▒░
   🟪 GRID STATUS: JACKED IN   |   netrunner-review: pass

The PR refactors the Android build process to use pre-committed Gradle templates and removes the need for runtime template application. It also moves TypeScript binding generation from the CLI to an xtask build script. The CI is green, and the changes appear to be well-structured and correctly implemented.


📡 NETWATCH · gate checks

codecov/patchsuccess
Run vitestsuccess
Run nextestsuccess
syncskipped
automergeskipped
Rust Security Auditsuccess
dependency-reviewsuccess
npm Security Auditsuccess
Convention & traceability gatesuccess

☠️ GLITCH TRACE · flaws & patches

⚪ TRACE · src-tauri/xtask/src/main.rs — The PR introduces a new xtask crate for generating TypeScript bindings. This is a good move as it centralizes the build process and ensures version consistency. However, ensure that the xtask is well-documented and maintained.

⚪ TRACE · .github/workflows/android-release.yml — The PR removes the need for runtime template application by committing the Gradle templates. This simplifies the build process but ensure that these templates are kept up-to-date and any changes are well-documented.

🟢 VERDICT // JACKED IN — deck's clean, netrunner-review gate open.

"Looks sharp, choom. Your chrome's polished and the ICE is thin. Keep running those decks smooth."
netrunner 🟪🔷

verdict: APPROVE · model: mistral-medium-2508

@thwbh

thwbh commented Jun 17, 2026

Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant