Draft
Conversation
As part of the work to fix the various races in teardown, implement shielding, use a v4 style sticky return, we need to consolidate control over the coroutine so that different behaviors can be swapped out at runtime. This moves control over _how_ a co-routine is reduced completely into the delimiter that sits around its currently executing body. This will allow us to "shield" segments of the effect stream, as well as enforce relentless returns.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issues #1153, #1154, and #1159 share a single root cause: cancellation
in v4 is one-shot.
The proposed fix is to have the co-routine, after cancellation, continually return, and return, and return with each yield, and then protect "critical" sections with a shield that makes normal execution for secments of the effect stream.
This PR is an attempt to enable these refactors by allowing the conetxt control exactly how the co-routine is advanced at every stem.
Approach
Invert control from the co-routine to the delimiter.