Repository navigation
release.sh: USNM_CURATED reads curated from a local copy (#308) - #1042
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The override is consistently quoted, preserves existing defaults, and has no unresolved review findings.
No open issues 🎉
What changed in this PR
Adds a local curated-data override for on-prem releases, reducing lake egress during rebuilds and finish replays while preserving the existing default.
Changes:
- Uses
USNM_CURATED, when set, for every--curatedargument. - Keeps the lake URL as the fallback when the override is unset or empty.
- Documents timestamp preservation for local copies and updates the usage output.
| File | Description |
|---|---|
scripts/onprem/release.sh |
Applies the curated-source override across all steps and documents local-copy requirements. |
Review effort: Balanced
This was referenced Oct 23, 2026
Every step passed the lake's curated URL. USNM_CURATED replaces it, so a local copy made with azcopy --preserve-last-modified-time can stand in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tgoodyear
force-pushed
the
onprem/curated-local
branch
from
October 25, 2026 11:31
c1e7928 to
c43327e
Compare
From Copilot's review of #1042: test_release.py looks for it verbatim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tgoodyear
pushed a commit
that referenced
this pull request
Oct 25, 2026
Takes main's local-curated option (USNM_CURATED, #1042) and Cosmos-access comment, and keeps the index_runs record; import-staged-run now reads $CURATED like the other calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-prem rebuilds read
curatedfrom the lake over the internet, about 0.5 TB of egress per full run (#308).release.shhard-coded the lake URL in every step. With this PR, whenUSNM_CURATEDis set, every step passes it as--curated, so a local directory can stand in for the lake.usnm-storealready treats any path that isn't http(s) as a local directory. Unset, nothing changes.The copy has to keep each blob's last-modified time as its file's modified time. A finish (#1007) lists curated as of the run's start by the objects' creation times, and a local store gives each file's modified time as its creation time.
azcopy copy --preserve-last-modified-timekeeps them, and curated objects are create-only, so last-modified matches creation for them.Tested with
bash -n,shellcheck -x -S warning, and the usage text.🤖 Generated with Claude Code