Repository navigation
fix(ByRole): treat inert elements as inaccessible - #1393
Open
YodHeVauHe wants to merge 2 commits into
Open
YodHeVauHe wants to merge 2 commits into
YodHeVauHe wants to merge 2 commits into
Conversation
Co-authored-by: ZaSourceCode <YodHeVauHe@users.noreply.github.com>
Role queries already honor hidden: true by skipping the inaccessible filter, so inert elements remain queryable when that option is set. Co-authored-by: ZaSourceCode <YodHeVauHe@users.noreply.github.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca965c2:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1364.
isSubtreeInaccessiblenever checkedelement.inert, so role queries still found inert elements. A defined, truthyelement.inertis now treated as inaccessible. Attribute presence is not used, so environments without the property stay unchanged.hidden: truestill includes those elements.npm test -- --runInBand src/__tests__/role.js -t "excludes inert elements by default but includes them with hidden: true"passed: 1 test (27 skipped in that file).