Skip to content

chore: remove eot fonts#2491

Merged
amir-ba merged 1 commit into
telekom:mainfrom
grigoriy-reshetniak:remove-eot-fonts
Jun 24, 2026
Merged

chore: remove eot fonts#2491
amir-ba merged 1 commit into
telekom:mainfrom
grigoriy-reshetniak:remove-eot-fonts

Conversation

@grigoriy-reshetniak

Copy link
Copy Markdown
Contributor

This PR removes .eot font files and their usage. It is an outdated font format which is not supported by any modern browser.

Derivative from #2481.

Copilot AI review requested due to automatic review settings April 28, 2026 16:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy .eot font assets and their @font-face references for the TeleNeoWeb font, keeping only modern woff2/woff sources.

Changes:

  • Removed .eot src: entries from TeleNeoWeb @font-face declarations.
  • Deleted TeleNeoWeb .eot font files from the repository.

Reviewed changes

Copilot reviewed 2 out of 14 changed files in this pull request and generated no comments.

File Description
packages/components/src/telekom/fonts/scale-fonts-telekom.css Drops .eot font sources from Telekom-specific font-face definitions.
packages/components/src/global/fonts.css Drops .eot font sources from the global font-face definitions.
packages/components/src/telekom/fonts/TeleNeoWeb/*.eot Removes obsolete .eot font binaries now that they’re no longer referenced.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amir-ba amir-ba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking correctness issue found in the diff. Could you link the tracking issue for dropping EOT font support? I see the decision came from the discussion in #2481, but there is no standalone issue linked here.

@grigoriy-reshetniak

Copy link
Copy Markdown
Contributor Author

There was no issue created for this PR, and I have a feeling I won't create one.

You see, telekom-scale isn't enjoying a lot of contributions (or maintainer activity) -- my previous PR was merged as-is, and even the comment that led to that PR was simply: "Create a PR", not "Create an issue". I don't see the point of creating an issue that would have zero activity just to be linked to a PR and closed immediately. This feels too close to the bureaucratic hoops I jump through every day at work, and it's not something I'd like to do in my free time.

Thank you for your review, I appreciate the time. However, the code is provided as-is, and if an issue is required on my part -- feel free to close the PR.

@amir-ba

amir-ba commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Frankly, I am disappointed by this response. While I understand that you are volunteering your time for free, please remember that the maintainers are doing the same. Describing a standard request for a tracking issue as 'bureaucratic hoops' is disingenuous and unfair to the people who are giving up their time to review your code for free.

We don't create busywork just for the sake of it. Like many projects, we are dealing with an influx of AI-generated pull requests that propose code without defining the actual problem. An issue provides the necessary context. Furthermore, we are currently developing automated review processes to speed up our cycles, and these rely entirely on having a documented problem linked to the PR.
While it's true that this isn't always necessary for legacy cleanup work like this one, creating an issue still helps us to review and merge your work faster.

@amir-ba

amir-ba commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2506

@amir-ba amir-ba merged commit 948e945 into telekom:main Jun 24, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants