Repository navigation
Conversation
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Diff between version 0.2 and 0.3diff --git a/task/kubernetes-actions/0.2/README.md b/task/kubernetes-actions/0.3/README.md
index f194c33..0c5b8a0 100644
--- a/task/kubernetes-actions/0.2/README.md
+++ b/task/kubernetes-actions/0.3/README.md
@@ -5,7 +5,7 @@ This is a generic task used to perform kubernetes actions such as `kubectl get d
## Install the task
```
-kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/kubernetes-actions/0.2/kubernetes-actions.yaml
+kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/kubernetes-actions/0.3/kubernetes-actions.yaml
```
## Inputs
@@ -34,7 +34,7 @@ The Task can be run on `linux/amd64` platform.
In case no manifests are mounted
```yaml
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: kubectl-run
@@ -52,7 +52,7 @@ spec:
In case manifest is present on `GitHub` :
```yaml
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: kubectl-run
@@ -77,7 +77,7 @@ Running `kubectl` commands on other cluster
2. Create the `TaskRun`
```yaml
- apiVersion: tekton.dev/v1beta1
+ apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: kubectl-run
diff --git a/task/kubernetes-actions/0.2/kubernetes-actions.yaml b/task/kubernetes-actions/0.3/kubernetes-actions.yaml
index 10cde71..01d68d6 100644
--- a/task/kubernetes-actions/0.2/kubernetes-actions.yaml
+++ b/task/kubernetes-actions/0.3/kubernetes-actions.yaml
@@ -1,11 +1,11 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: Task
metadata:
name: kubernetes-actions
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
- tekton.dev/pipelines.minVersion: "0.17.0"
+ tekton.dev/pipelines.minVersion: "0.50.0"
tekton.dev/categories: Kubernetes
tekton.dev/tags: CLI, kubectl
tekton.dev/displayName: "kubernetes actions"
diff --git a/task/kubernetes-actions/0.2/samples/kubectl-actions-run.yaml b/task/kubernetes-actions/0.3/samples/kubectl-actions-run.yaml
index 977d53e..07acbb8 100644
--- a/task/kubernetes-actions/0.2/samples/kubectl-actions-run.yaml
+++ b/task/kubernetes-actions/0.3/samples/kubectl-actions-run.yaml
@@ -1,4 +1,4 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: kubectl-run
diff --git a/task/kubernetes-actions/0.2/samples/update-deployment-image-taskrun.yaml b/task/kubernetes-actions/0.3/samples/update-deployment-image-taskrun.yaml
index 07ca3e6..5f05a73 100644
--- a/task/kubernetes-actions/0.2/samples/update-deployment-image-taskrun.yaml
+++ b/task/kubernetes-actions/0.3/samples/update-deployment-image-taskrun.yaml
@@ -1,5 +1,5 @@
---
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: update-deployment-image-taskrun
diff --git a/task/kubernetes-actions/0.2/tests/resources.yaml b/task/kubernetes-actions/0.3/tests/resources.yaml
index 97fac20..cca0ad9 100644
--- a/task/kubernetes-actions/0.2/tests/resources.yaml
+++ b/task/kubernetes-actions/0.3/tests/resources.yaml
@@ -3,7 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: kubernetes-actions-account
- namespace: kubernetes-actions-0-2
+ namespace: kubernetes-actions-0-3
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
@@ -30,7 +30,7 @@ metadata:
subjects:
- kind: ServiceAccount
name: kubernetes-actions-account
- namespace: kubernetes-actions-0-2
+ namespace: kubernetes-actions-0-3
roleRef:
kind: ClusterRole
name: kubernetes-actions-role
diff --git a/task/kubernetes-actions/0.2/tests/run.yaml b/task/kubernetes-actions/0.3/tests/run.yaml
index 29bb4b7..4d72452 100644
--- a/task/kubernetes-actions/0.2/tests/run.yaml
+++ b/task/kubernetes-actions/0.3/tests/run.yaml
@@ -1,4 +1,4 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
kind: TaskRun
metadata:
name: kubernetes-actions-run |
Contributor
Author
|
/assign @vinamra28 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Mechanical API version bump for the kubernetes/EKS task family, as part of the
v1beta1 → v1 migration tracked in #1381.
Tasks updated
Each task was created using
copy-then-modifyper CONTRIBUTING.md: one commitcopies the previous version directory, a second commit applies the version bump.
None of these tasks use PipelineResources or other v1beta1-only constructs.
Additional fix
kubectl-deploy-pod/0.2/support/clusterrolebinding.yamlwas usingrbac.authorization.k8s.io/v1beta1, which has been removed since Kubernetes 1.22.Bumped to
rbac.authorization.k8s.io/v1.Image pinning
All images in these tasks are either already pinned by digest (
eksctl:0.35.0@sha256:...,busybox:1.32.0@sha256:...) or referenced via$(params.image)(user-controlled).No additional pinning was needed.
Validation
yamllintpasses for all modified files (two pre-existing comment-spacing warnings inherited from upstream)tekton.dev/v1beta1references in any of the new version directoriesNote on pre-existing conditions
eks-cluster-createandeks-cluster-teardowninterpolate$(params.*)directly inscript:blocks.kubernetes-actionstakes its entire script via$(params.script).Those patterns are inherited from the previous versions and not introduced by this PR.
Script injection hardening will be addressed in follow-up PRs as part of #1381.
Ref: #1381
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yamlHas
README.mdat<kind>/<name>/<version>/README.mdHas mandatory
metadata.labels-app.kubernetes.io/versionthe same as the<version>of the resourceHas mandatory
metadata.annotationstekton.dev/pipelines.minVersionmandatory
spec.descriptionfollows the conventionSee the contribution guide for more details.