fix: remove silent failure from release-please github-release step#329
Merged
Merged
Conversation
The || true was silently swallowing tag creation failures. This caused the v4.162.0 release to silently fail — the workflow reported success but no tag/release was created. Root cause was the tag protection ruleset blocking SDK_WRITE_TOKEN. Fixed by adding the token's actor to the ruleset bypass list. Now that the bypass is in place, removing || true ensures any future failures are visible instead of silently swallowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
|| trueafter the github-release command was silently swallowing tag creation failures.Problem
When release-please tried to create the v4.162.0 tag/release, the tag protection ruleset blocked it. The
|| trueswallowed the error, so the workflow reported success but no tag or release was created. This was only discovered when PyPI publish didn't trigger.Fix
|| trueso future failures are visibleContext
Part of the STLC promote cutover for Python SDK.