Consolidate repeated App-layer patterns and reduce duplication

[DysektAI]

Summary

This is a focused cleanup pass that removes obvious, low-risk duplication across src/App without changing product behavior.

• SimpleConfig: replaced six nearly-identical try { parse(...) } catch { return defaultValue; } read methods with one ReadOrDefault<T> helper.
• TarkovDev/JsonApiModels: extracted Identifiable / Entity / NamedEntity base classes so the id, name, and normalizedName JSON properties are declared once.
• TarkovDevAPI: offline cache loading now reuses the existing MaterializeCachedArray method (removing six duplicated JsonConvert.DeserializeObject lambdas), and the craft/barter fetch methods now share a generic FetchJObjectListAsync<T> pipeline.
• ItemExtensions: merged the identical mark and buildWeapon objective branches into a single pattern check.
• MapDataLoader: replaced four repeated cache-reset assignments with a ResetCache helper.
• TarkovTrackerDB: extracted the token/endpoint/mode equality check into IsCurrentConfiguration and called it from both Configure and token validation.
• ActiveHotkey: collapsed four constructor overloads into two constructors plus a shared Initialize method, removing duplicated listener wiring.
• Logger: ProcessBacklog and Flush now share a single FlushBacklogLocked implementation.
• UserActivityHelper: added ThrowLastWin32Error and used it for the three identical Marshal.GetLastWin32Error() / new Win32Exception(...) blocks.

All changes were validated with:

dotnet build RatScanner.sln
dotnet test RatScanner.sln
dotnet tool restore && dotnet csharpier check .

(dotnet was not initially on PATH; the .NET 10 SDK was installed via Chocolatey and RatEye submodules were initialized before building.)

Link to Devin session: https://app.devin.ai/sessions/dd0b650ddf6e4ff69c9a1061d1667e5f
Requested by: @DysektAI

---

---

Summary by cubic

Consolidates repeated App-layer patterns to reduce duplication and centralize logic. No behavior changes; improves readability and maintenance.

• Refactors
  • Config: added ReadOrDefault and condensed read methods (string, secure string, int, float, bool, enum lists).
  • API: offline cache now uses MaterializeCachedArray; crafts/barters share FetchJObjectListAsync; simplified TryLoadFromOfflineCache.
  • Models: introduced Identifiable/Entity/NamedEntity base classes to dedupe id/name/normalizedName.
  • Hotkeys: reduced constructors to two and centralized setup via Initialize; tightened nullability.
  • Items: unified mark and buildWeapon objective handling.
  • Maps: added ResetCache helper for repeated cache clears.
  • Tracker DB: extracted IsCurrentConfiguration for token/endpoint/mode checks.
  • Logger: shared FlushBacklogLocked used by backlog processing and flush.
  • User activity: added ThrowLastWin32Error and preserved original Win32 error code during cleanup rollback.

^{Written for commit 3d5623e. Summary will update on new commits.}

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability when keyboard or mouse activity hooks fail to start or stop.
  • Improved handling of missing map data by safely resetting cached map information.
  • Preserved objective progress calculations for marking and weapon-building tasks.

• Refactor

  • Improved configuration reading with consistent “read or default” behavior.
  • Centralized logging backlog flushing for more consistent log output.
  • Streamlined offline cache loading and API data processing for crafts/barters.
  • Simplified hotkey and event handling setup; improved internal model reuse for JSON parsing.

Walkthrough

The pull request consolidates repeated helper logic across configuration, logging, cache handling, API parsing, input hooks, and JSON models. It also combines mark/build-weapon objective handling and centralizes current-configuration checks.

Changes

Application refactors

Layer / File(s)	Summary
JSON models and API data loading src/App/TarkovDev/JsonApiModels.cs, src/App/TarkovDevAPI.cs	Shared JSON base classes, query-key-based offline cache materialization, and generic craft/barter envelope parsing are introduced.
Configuration and input helpers src/App/SimpleConfig.cs, src/App/TarkovTrackerDB.cs, src/App/ActiveHotkey.cs, src/App/UserActivityHelper.cs	Configuration reads, configuration comparisons, hotkey initialization, and Win32 error handling are centralized through shared helpers.
Runtime utility consolidation src/App/Logger.cs, src/App/MapDataLoader.cs, src/App/ItemExtensions.cs	Backlog flushing, map cache reset behavior, and mark/build-weapon objective matching are consolidated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• tarkovtracker-org/RatScanner#2: Both changes modify the ActiveHotkey infrastructure.

Suggested labels: size:XXL

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the PR's main refactor theme and matches the changeset.
Description check	✅ Passed	The description closely matches the refactor-focused changes and is on-topic.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch devin/deduplicate-quick-wins

---

_{Comment @coderabbitai help to get the list of available commands.}