Fix name scan after BSG magnifier change and language switch race#1
Open
Syklass wants to merge 2 commits into
Open
Fix name scan after BSG magnifier change and language switch race#1Syklass wants to merge 2 commits into
Syklass wants to merge 2 commits into
Conversation
Load the search marker from Data/icon_search.png with scale calibrated to the new template width. Preload offline item cache on startup and resolve items via TryGetItemById to avoid crashes when the cache is still loading after a language change. Unregister hotkeys while saving settings and skip scans gracefully when an item is not cached yet. Track icon_search.png in repo: required for Name Scan after BSG magnifier UI change. Bump version to 3.9.4.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes add cached item lookup and scan guards, centralize inspection configuration, guarantee hotkey restoration during settings saves, and add VS Code build/debug/publish configuration. The shipped search icon path and project version are also updated. ChangesScanner cache and scan handling
Settings hotkey lifecycle
Development and release configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Comment on lines
+59
to
+62
| internal SettingsVM(LocalizationService localizationService) { | ||
| _localizationService = localizationService; | ||
| LoadSettings(); | ||
| } |
There was a problem hiding this comment.
Suggestion: Add an explicit null check for the localizationService constructor argument before assigning it so later calls cannot dereference a null dependency. [custom_rule]
Severity Level: Major
Why it matters? ⭐
The constructor stores localizationService directly into a field and then later uses _localizationService.SetLanguage(...) without any explicit null guard or validation. This matches the nullable-handling rule because a null dependency could be propagated and dereferenced later.
Rule source 📖
=== AGENTS.md === (line 66)
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** RatScanner/ViewModel/SettingsVM.cs
**Line:** 59:62
**Comment:**
*Custom Rule: Add an explicit null check for the `localizationService` constructor argument before assigning it so later calls cannot dereference a null dependency.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Comment on lines
+318
to
+321
| if (!TarkovDevAPI.TryGetItemById(inspection.Item!.Id, out _)) { | ||
| Logger.LogWarning($"Skipping name scan: item {inspection.Item.Id} is not in cache yet."); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggestion: Add an explicit null guard for inspection.Item at the start of the helper and avoid relying on the null-forgiving operator when reading the item id. [custom_rule]
Severity Level: Major
Why it matters? ⭐
The helper dereferences inspection.Item with the null-forgiving operator instead of explicitly guarding it. This is a changed C# nullable-reference usage without explicit null handling, so the suggestion matches the custom rule.
Rule source 📖
=== AGENTS.md === (line 66)
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** RatScanner/RatScannerMain.cs
**Line:** 318:321
**Comment:**
*Custom Rule: Add an explicit null guard for `inspection.Item` at the start of the helper and avoid relying on the null-forgiving operator when reading the item id.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| RatConfig.ToolTip.Duration); | ||
|
|
||
| ItemScans.Enqueue(tempNameScan); | ||
| TryEnqueueNameScan(inspection, toolTipPosition); |
There was a problem hiding this comment.
Suggestion: Add an explicit null check for the nullable inspection value in the loop before passing it to the enqueue helper. [custom_rule]
Severity Level: Major
Why it matters? ⭐
The loop variable is declared as Inspection? inspection, but the code passes it directly to TryEnqueueNameScan without an explicit null check. That is a nullable-reference usage introduced in changed code and is not explicitly handled, so the rule applies.
Rule source 📖
=== AGENTS.md === (line 66)
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** RatScanner/RatScannerMain.cs
**Line:** 354:354
**Comment:**
*Custom Rule: Add an explicit null check for the nullable `inspection` value in the loop before passing it to the enqueue helper.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
| InventoryConfig = new Config.Processing.Inventory() { | ||
| OptimizeHighlighted = highlighted, | ||
| }, | ||
| InspectionConfig = CreateInspectionConfig(), |
There was a problem hiding this comment.
Suggestion: CreateInspectionConfig() allocates a new Bitmap each time RatEye is reconfigured, but no disposal path is introduced for previously created marker bitmaps, which can leak GDI handles/memory over repeated SetupRatEye calls. Ensure old inspection marker resources are disposed when replacing the engine/config. [resource leak]
Severity Level: Major ⚠️
⚠️ RatEye reconfiguration accumulates GDI handles over time.
⚠️ Long-running sessions risk memory/handle exhaustion during scans.Steps of Reproduction ✅
1. Start the application so that `RatScannerMain` is constructed
(`RatScanner/RatScannerMain.cs:19-83`), which logs "Initializing RatEye..." and calls
`SetupRatEye()` at line 58-59.
2. In `SetupRatEye()` (`RatScanner/RatScannerMain.cs:35-41`), a new `RatEyeEngine`
instance is created with `GetRatEyeConfig()`, which in turn sets
`ProcessingConfig.InspectionConfig = CreateInspectionConfig()`
(`RatScanner/RatScannerMain.cs:43-60).
3. `CreateInspectionConfig()` (`RatScanner/RatScannerMain.cs:64-70`) allocates a new
`Bitmap` from `RatConfig.Paths.SearchIcon` and assigns it to the `Marker` property of the
`Config.Processing.Inspection` object; no disposal of previous markers or the created
bitmap is performed here.
4. Later, when the item cache becomes ready, `WaitForItemsAndSeedAsync()`
(`RatScanner/RatScannerMain.cs:101-114`) calls `SetupRatEye()` again at line 107, creating
a second `RatEyeEngine` and a new inspection config marker bitmap; the previous
`RatEyeEngine` and its `InspectionConfig.Marker` are replaced without an explicit
`Dispose` call, so repeated reconfiguration within a long-lived process will continually
allocate new marker bitmaps, relying only on GC/finalizers and effectively leaking GDI
handles until collection.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** RatScanner/RatScannerMain.cs
**Line:** 208:208
**Comment:**
*Resource Leak: `CreateInspectionConfig()` allocates a new `Bitmap` each time RatEye is reconfigured, but no disposal path is introduced for previously created marker bitmaps, which can leak GDI handles/memory over repeated `SetupRatEye` calls. Ensure old inspection marker resources are disposed when replacing the engine/config.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Comment on lines
118
to
+173
| @@ -123,11 +125,11 @@ public async Task SaveSettings() { | |||
| RatConfig.IconScan.Enable = EnableIconScan; | |||
| RatConfig.IconScan.ScanRotatedIcons = ScanRotatedIcons; | |||
| RatConfig.IconScan.UseCachedIcons = UseCachedIcons; | |||
| RatConfig.IconScan.Hotkey = IconScanHotkey; | |||
|
|
|||
| RatConfig.ToolTip.Duration = int.TryParse(ToolTipDuration, out int i) ? i : 0; | |||
| RatConfig.ToolTip.Duration = ToolTipMilli; | |||
| RatConfig.UserInterface.Language = UiLanguage; | |||
| RatConfig.IconScan.Hotkey = IconScanHotkey; | |||
| RatConfig.ToolTip.Duration = int.TryParse(ToolTipDuration, out int i) ? i : 0; | |||
| RatConfig.ToolTip.Duration = ToolTipMilli; | |||
| RatConfig.UserInterface.Language = UiLanguage; | |||
|
|
|||
| RatConfig.MinimalUi.ShowName = ShowName; | |||
| RatConfig.MinimalUi.ShowAvgDayPrice = ShowAvgDayPrice; | |||
| @@ -163,11 +165,13 @@ public async Task SaveSettings() { | |||
| PageSwitcher.Instance.ResetWindowSize(); | |||
| await TarkovDevAPI.InitializeCache(); | |||
| if (updateTarkovTrackerToken || updateTarkovTrackerBackend) UpdateTarkovTrackerToken(); | |||
| if (updateUiLanguage) _localizationService.SetLanguage(UiLanguage); | |||
| if (updateResolution || updateLanguage) RatScannerMain.Instance.SetupRatEye(); | |||
| if (updateUiLanguage) _localizationService.SetLanguage(UiLanguage); | |||
| if (updateResolution || updateLanguage) RatScannerMain.Instance.SetupRatEye(); | |||
|
|
|||
| RatEye.Config.LogDebug = RatConfig.LogDebug; | |||
| RatScannerMain.Instance.HotkeyManager.RegisterHotkeys(); | |||
| } finally { | |||
| RatScannerMain.Instance.HotkeyManager.RegisterHotkeys(); | |||
There was a problem hiding this comment.
Suggestion: Saving settings now always unregisters and re-registers hotkeys, but the hotkey cleanup path does not dispose all registered hotkeys (the close-overlay hotkey is left alive), so each save adds another active handler. This causes accumulating listeners and resource leakage over time; either fully dispose all hotkeys in the manager or avoid full re-registration here. [missing cleanup]
Severity Level: Major ⚠️
⚠️ Escape close overlay hotkey accumulates multiple active listeners.
⚠️ Extra handlers increase event dispatch and background work.
⚠️ Hotkey lifecycle inconsistent; destructor never cleans close hotkey.Steps of Reproduction ✅
1. Inspect application startup flow in `RatScanner/RatScannerMain.cs:12-20`: the
constructor creates `HotkeyManager = new HotkeyManager();` (line 13), whose constructor
(`RatScanner/HotkeyManager.cs:20-23`) calls `RegisterHotkeys()` and creates
`NameScanHotkey`, `IconScanHotkey`, `OpenInteractableOverlayHotkey`, and
`CloseInteractableOverlayHotkey` (lines 46-50). Immediately after, `RatScannerMain` calls
`HotkeyManager.UnregisterHotkeys();` (line 14).
2. Examine `HotkeyManager.UnregisterHotkeys()` in `RatScanner/HotkeyManager.cs:56-60`: it
disposes `NameScanHotkey`, `IconScanHotkey`, and `OpenInteractableOverlayHotkey`, but does
not dispose `CloseInteractableOverlayHotkey`, leaving its `UserActivityHelper` event
subscriptions active (see `ActiveHotkey.Dispose()` in
`RatScanner/ActiveHotkey.cs:117-119`, which unregisters event listeners).
3. Inspect settings save flow: the Save button in
`RatScanner/Pages/App/Settings/SettingsSave.razor:24-29` calls `SettingsVM.SaveSettings()`
(line 26). In `SaveSettings` (`RatScanner/ViewModel/SettingsVM.cs:110-174`), line 118
calls `RatScannerMain.Instance.HotkeyManager.UnregisterHotkeys();`, and the `finally`
block at lines 172-173 calls `RatScannerMain.Instance.HotkeyManager.RegisterHotkeys();`,
which itself begins by calling `UnregisterHotkeys()` again (`HotkeyManager.cs:42-44`) and
then re-creates all four hotkeys, including a new `CloseInteractableOverlayHotkey` (line
50).
4. Because `UnregisterHotkeys()` never disposes `CloseInteractableOverlayHotkey`, each
call sequence `UnregisterHotkeys()` → `RegisterHotkeys()` during startup and every
settings save leaves existing close-hotkey instances subscribed and creates a new one.
Over time, multiple `ActiveHotkey` instances for Escape accumulate, all handling key-up
events via `ActiveHotkey.OnKeyUp` (`ActiveHotkey.cs:86-92`). Pressing Escape to close the
interactable overlay will trigger multiple handlers and the app retains unnecessary event
subscriptions, demonstrating a real resource leak tied directly to `SaveSettings()` usage.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** RatScanner/ViewModel/SettingsVM.cs
**Line:** 118:173
**Comment:**
*Missing Cleanup: Saving settings now always unregisters and re-registers hotkeys, but the hotkey cleanup path does not dispose all registered hotkeys (the close-overlay hotkey is left alive), so each save adds another active handler. This causes accumulating listeners and resource leakage over time; either fully dispose all hotkeys in the manager or avoid full re-registration here.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@RatScanner/RatScannerMain.cs`:
- Around line 213-220: Update CreateInspectionConfig to validate that
RatConfig.Paths.SearchIcon exists before constructing the Bitmap. If the file is
missing, throw or report a clear user-facing error that identifies
icon_search.png and instructs the user to update or reinstall the RatScannerData
bundle, while preserving the existing inspection configuration for valid files.
In `@RatScanner/ViewModel/SettingsVM.cs`:
- Around line 130-131: Remove the redundant assignment that parses
ToolTipDuration, leaving the RatConfig.ToolTip.Duration assignment from
ToolTipMilli as the sole tooltip-duration update in the settings save flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2db570e8-472b-41f1-ba8f-9dff49d3941d
⛔ Files ignored due to path filters (1)
RatScanner/Data/icon_search.pngis excluded by!**/*.png
📒 Files selected for processing (10)
.gitignore.vscode/launch.json.vscode/tasks.jsonRatScanner/RatConfig.csRatScanner/RatScanner.csprojRatScanner/RatScannerMain.csRatScanner/Scan/ItemIconScan.csRatScanner/Scan/ItemNameScan.csRatScanner/TarkovDevAPI.csRatScanner/ViewModel/SettingsVM.cs
Comment on lines
+213
to
+220
| private static Config.Processing.Inspection CreateInspectionConfig() { | ||
| var marker = new Bitmap(RatConfig.Paths.SearchIcon); | ||
| // MarkerItemScale is calibrated to template width: in-game icon is ~16px at 1080p | ||
| return new Config.Processing.Inspection() { | ||
| Marker = marker, | ||
| MarkerItemScale = 16f / marker.Width, | ||
| }; | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Guard against missing icon_search.png to prevent startup crash.
new Bitmap(RatConfig.Paths.SearchIcon) throws FileNotFoundException if the file is absent, crashing the app during SetupRatEye with no user-friendly message. If the RatScannerData bundle is not updated, users get an unhandled exception instead of actionable guidance.
🛡️ Proposed fix: file-existence check with helpful error
private static Config.Processing.Inspection CreateInspectionConfig() {
+ if (!File.Exists(RatConfig.Paths.SearchIcon)) {
+ Logger.LogError($"Search icon not found at: {RatConfig.Paths.SearchIcon}. Ensure the RatScannerData bundle is up to date.");
+ throw new FileNotFoundException("Search icon file is missing. Please update the RatScannerData bundle.", RatConfig.Paths.SearchIcon);
+ }
var marker = new Bitmap(RatConfig.Paths.SearchIcon);
// MarkerItemScale is calibrated to template width: in-game icon is ~16px at 1080p
return new Config.Processing.Inspection() {
Marker = marker,
MarkerItemScale = 16f / marker.Width,
};
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| private static Config.Processing.Inspection CreateInspectionConfig() { | |
| var marker = new Bitmap(RatConfig.Paths.SearchIcon); | |
| // MarkerItemScale is calibrated to template width: in-game icon is ~16px at 1080p | |
| return new Config.Processing.Inspection() { | |
| Marker = marker, | |
| MarkerItemScale = 16f / marker.Width, | |
| }; | |
| } | |
| private static Config.Processing.Inspection CreateInspectionConfig() { | |
| if (!File.Exists(RatConfig.Paths.SearchIcon)) { | |
| Logger.LogError($"Search icon not found at: {RatConfig.Paths.SearchIcon}. Ensure the RatScannerData bundle is up to date."); | |
| throw new FileNotFoundException("Search icon file is missing. Please update the RatScannerData bundle.", RatConfig.Paths.SearchIcon); | |
| } | |
| var marker = new Bitmap(RatConfig.Paths.SearchIcon); | |
| // MarkerItemScale is calibrated to template width: in-game icon is ~16px at 1080p | |
| return new Config.Processing.Inspection() { | |
| Marker = marker, | |
| MarkerItemScale = 16f / marker.Width, | |
| }; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@RatScanner/RatScannerMain.cs` around lines 213 - 220, Update
CreateInspectionConfig to validate that RatConfig.Paths.SearchIcon exists before
constructing the Bitmap. If the file is missing, throw or report a clear
user-facing error that identifies icon_search.png and instructs the user to
update or reinstall the RatScannerData bundle, while preserving the existing
inspection configuration for valid files.
Guard missing icon_search.png with a clear Logger.LogError path, reuse one Bitmap across RatEye reconfigs, make TryGetItemById cache-only and game-mode-scoped so scans never queue fetches or leak cross-mode data, and drop the dead ToolTipDuration parse on settings save.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@RatScanner/RatScannerMain.cs`:
- Around line 215-233: Update CreateInspectionConfig so a missing
RatConfig.Paths.SearchIcon does not continue to new Bitmap(path). After logging
the existing actionable guidance, throw an exception using that same custom
message so the user-facing failure includes reinstall/update instructions and
avoids the generic FileNotFoundException.
In `@RatScanner/ViewModel/SettingsVM.cs`:
- Around line 171-173: Update HotkeyManager.UnregisterHotkeys() to dispose and
clear CloseInteractableOverlayHotkey alongside the other hotkeys. Ensure
RegisterHotkeys() can safely create a new Escape listener after each save
without retaining prior subscriptions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c772bfbd-fa26-4b49-a233-19f9db183de4
📒 Files selected for processing (3)
RatScanner/RatScannerMain.csRatScanner/TarkovDevAPI.csRatScanner/ViewModel/SettingsVM.cs
Comment on lines
+215
to
+233
| private Config.Processing.Inspection CreateInspectionConfig() { | ||
| if (_searchMarker == null) { | ||
| string path = RatConfig.Paths.SearchIcon; | ||
| if (!File.Exists(path)) { | ||
| Logger.LogError( | ||
| $"Search icon not found at: {path}\n\n" + | ||
| "Name scan requires Data/icon_search.png. Reinstall or update RatScanner so the full package is present."); | ||
| } | ||
|
|
||
| _searchMarker = new Bitmap(path); | ||
| Logger.LogInfo($"Loaded name-scan marker {_searchMarker.Width}x{_searchMarker.Height} from {path}"); | ||
| } | ||
|
|
||
| // MarkerItemScale is calibrated to template width: in-game icon is ~16px at 1080p | ||
| return new Config.Processing.Inspection() { | ||
| Marker = _searchMarker, | ||
| MarkerItemScale = 16f / _searchMarker.Width, | ||
| }; | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Missing-file check logs but still crashes with an unhelpful exception.
The File.Exists check at line 218 logs a helpful message, but execution falls through to new Bitmap(path) at line 224, which throws FileNotFoundException with a generic .NET message. The user sees an unhandled exception dialog with no actionable guidance — the helpful text is only in the log file. This partially addresses the prior review's concern but leaves the user-facing crash experience unimproved.
🛡️ Proposed fix: throw with the custom message
private Config.Processing.Inspection CreateInspectionConfig() {
if (_searchMarker == null) {
string path = RatConfig.Paths.SearchIcon;
if (!File.Exists(path)) {
Logger.LogError(
$"Search icon not found at: {path}\n\n" +
"Name scan requires Data/icon_search.png. Reinstall or update RatScanner so the full package is present.");
- }
-
- _searchMarker = new Bitmap(path);
+ throw new FileNotFoundException(
+ "Search icon file is missing. Name scan requires Data/icon_search.png. Reinstall or update RatScanner so the full package is present.",
+ path);
+ }
+
+ _searchMarker = new Bitmap(path);
Logger.LogInfo($"Loaded name-scan marker {_searchMarker.Width}x{_searchMarker.Height} from {path}");
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@RatScanner/RatScannerMain.cs` around lines 215 - 233, Update
CreateInspectionConfig so a missing RatConfig.Paths.SearchIcon does not continue
to new Bitmap(path). After logging the existing actionable guidance, throw an
exception using that same custom message so the user-facing failure includes
reinstall/update instructions and avoids the generic FileNotFoundException.
Comment on lines
+171
to
+173
| } finally { | ||
| RatScannerMain.Instance.HotkeyManager.RegisterHotkeys(); | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify CloseInteractableOverlayHotkey disposal coverage in HotkeyManager
rg -n "CloseInteractableOverlayHotkey" RatScanner/HotkeyManager.cs -C3Repository: tarkovtracker-org/RatScanner
Length of output: 1587
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== HotkeyManager.cs ==\n'
sed -n '1,140p' RatScanner/HotkeyManager.cs
printf '\n== ActiveHotkey definitions/usages ==\n'
rg -n "class ActiveHotkey|Dispose\(|CloseInteractableOverlayHotkey|UnregisterHotkeys\(" RatScanner -C 3
printf '\n== SettingsVM save path around the finally block ==\n'
sed -n '150,190p' RatScanner/ViewModel/SettingsVM.csRepository: tarkovtracker-org/RatScanner
Length of output: 16283
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== ActiveHotkey.cs ==\n'
sed -n '1,180p' RatScanner/ActiveHotkey.cs
printf '\n== RatScannerMain.cs around HotkeyManager startup ==\n'
sed -n '80,110p' RatScanner/RatScannerMain.cs
printf '\n== Any explicit CloseInteractableOverlayHotkey disposal elsewhere ==\n'
rg -n "CloseInteractableOverlayHotkey.*Dispose|Dispose\(\).*CloseInteractableOverlayHotkey|CloseInteractableOverlayHotkey" RatScanner -C 2Repository: tarkovtracker-org/RatScanner
Length of output: 8360
Dispose CloseInteractableOverlayHotkey in HotkeyManager.UnregisterHotkeys()
UnregisterHotkeys() disposes the other three hotkeys but leaves CloseInteractableOverlayHotkey subscribed. With RegisterHotkeys() reassigning that field each time, every save leaves the previous Escape listener alive and adds another one.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@RatScanner/ViewModel/SettingsVM.cs` around lines 171 - 173, Update
HotkeyManager.UnregisterHotkeys() to dispose and clear
CloseInteractableOverlayHotkey alongside the other hotkeys. Ensure
RegisterHotkeys() can safely create a new Escape listener after each save
without retaining prior subscriptions.
Nivmizz7
reviewed
Jul 11, 2026
Member
There was a problem hiding this comment.
the .vscode/ dir is not on the .gitignore normally?
Nivmizz7
reviewed
Jul 11, 2026
Nivmizz7
requested changes
Jul 11, 2026
Member
There was a problem hiding this comment.
there is no automatic CI/CD to upgrade version and create release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Data/icon_search.pngwith updatedMarkerItemScaleTryGetItemByIdto avoidUnknown itemduring language switchesRelated issue
Fixes #... (если есть issue; иначе опиши баг)
Test plan
dotnet build RatScanner.sln -c ReleaseData/icon_search.pngpresent locally (note for release: needs RatScannerData update)Release note
Requires updated
icon_search.pngin the Data bundle (RatScannerData).CodeAnt-AI Description
Fix name scans during language changes and restore search marker detection after the BSG magnifier update
What Changed
Impact
✅ Fewer scan crashes after changing language✅ Restored name scanning with the new magnifier UI✅ Fewer missed scans while item data is still loading💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.