Repository navigation
session: preserve latest window size when consumer drains buffer - #17
Merged
Merged
Conversation
The nonblocking window-change path only retried its send when it drained the stale buffered value itself. If the PTY consumer drained that value first, the latest size was silently lost. Retry the send after either drain outcome while keeping channel operations nonblocking. Add a per-session test gate and a deterministic regression test for the consumer-drains-before-discard interleaving. Fixes: #15 / 6662764 (session: don't park request loop on window-change, bound env churn)
raggi
force-pushed
the
raggi/gliderssh-sendwindow
branch
from
October 26, 2026 14:32
5a3122e to
791b498
Compare
raggi
changed the title
jentfoo
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nonblocking window-change path only retried its send when it drained the stale buffered value itself. If the PTY consumer drained that value first, the latest size was silently lost.
Retry the send after either drain outcome while keeping channel operations nonblocking. Add a per-session test gate and a deterministic regression test for the consumer-drains-before-discard interleaving.
Fixes: #15 / 6662764 (session: don't park request loop on window-change, bound env churn)