Gillespie 1318 timedep#1329
Merged
luciansmith merged 2 commits intoJun 9, 2026
Merged
Conversation
…rules The timeDependentRates comment claimed the fix handles time entering through a rate rule. It does not: Gillespie freezes the state vector between reaction events and never integrates a rate-rule variable, so setTime() alone does not advance it and it is neither detected nor tracked by the propensity integral. Drop the rate-rule claim and state the limitation explicitly. Comment-only; no behavior change.
Same fix as the header comment, in the duplicate that sat in the .cpp. A rate-rule variable is part of the frozen state, so it does not vary across the detection probes; time dependence entering through a rate rule is not detected (and not handled) here. Comment-only.
luciansmith
merged commit a681d8a
into
sys-bio:issue-1318-time-dep-gillespie
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.